#474 Splines: solid fill in additional layers
The new spline feature is great, exactly what I have been waiting for ages. Thanks!
But there seems to be a bug. I have ~30 layers in three of them I drew some splines, which looked fine. But after enabling some other layers the splines got something like a solid hatching, see attached image. That depends on the line style of the spline layers. The big chunks of white are filling continuous splines, the shorters bits appear where the splines are dashed.
The color of this "fill" is from the additional layer I activate. When there are multiple additional layers activated it seems to be random which layer's color it is.
Strangely there are still some layers that I can activate without affecting the splines. But I can't make out any difference between those layers.
I won't publish my DXF here but would be glad to email it privately.
Can you attach a testcase dxf file and detailed steps to reproduce this bug?
Apparently solid fills are causing this problem. If there is just one solid fill in that file it will also fill the splines, even if the splines were drawn after fill, are in differen, locked layers etc.
See attached file
Further Investigation taught me that the arrows drawn by the 'dimensions' menu aparrently also use solid fills internaly. Because just removing all the self-made solid fills from my file did not solve the problem, I would have to delete everything with an arrow as well (dimensions AND labels).
Yeah, now I replaced all solid fills by a very dense hatch and removed all features drawn by the dimensions menu. That's now a tested workaround to avoid this problem.
Is this a bug due to spline or solid fill?
If there's a bug, we have to fix it.
IMHO it is definetely a bug! Which module is faulty I can not tell.
But odds are that the new (otherwise fantastic) interpolation spline is faulty, because the classic splines are not affected. Also objects like polylines or circles are not affected.
More observations:
When selecting the original fill the unwanted fill in the splines disappears, everything looks right. But after deselection it's the same snafu all over.
While the new interpolation splines are really eager on getting filled, the classic ones are impossible to fill. I don not know whether that is intended. Hatches are not possible for both of them...
Attached a testcase dxf spline_474.dxf. The whilte splines (layer 0) are by Draw->"Spline through points", and the red splines (layer 1) are by Draw->"spline"
steps to reproduce this bug:
o, open the spline_474.dxf;
1, Main menu: Draw -> Hatch;
2, Select the white closed spline located top-left to hatch, and click Next button;
3, in Hatch pattern dialog, check the "solid Fill" option, and click "Ok"
Expected result:
The white closed spline is hatched. No change to other three splines.
Actual result:
All 4 splines are filled.
In step 2, choosing any spline in the drawing leads to the same result.
pushed a fix in master branch, commit 15b103e..0d07caa master -> master
TODO, enable hatching for "spline points", but we probably won't enable hatching for old style spline.