From: <pl...@ip...> - 2005-05-28 01:29:21
|
> In include/quicktime/colormodels.h there are several FOURCC_ lines. One > of them 1) is basically mislabeled and 2) should, I think, > be a QUICKTIME_xxx entry in quicktime.h > > #define FOURCC_YUV2 0x32595559 /* YUV2 YUV422 */ > > It's not YUV2. Rather it is YUY2. Now YUY2 is a 'video range' > packed 4:2:2 format and should (I think) have a QUICKTIME_YUY2 > entry in <quicktime.h>. YUY2 is the byte flipped version of 2VUY. > > There is a QUICKTIME_2VUY (I added that a little while ago) so would it > be a good idea to have a QUICKTIME_YUY2 as well (and change all > references to FOURCC_YUV2 to QUICKTIME_YUY2)? The only reference I can find is in lqtplay.c and lqtvrplay.c, so they should be defined locally there (together with the other FOURCC_ macros). They are just fourccs supported by XVideo and FOURCC_YUV2 should be chang= ed to FOURCC_YUY2. That reminds me, that lqtplay and lqtvrplay share a lot of code, so each fix must be applied twice. Could it be possible to merge them into one file? Cheers Burkhard |