libposix-development Mailing List for libposix (Page 3)
Status: Pre-Alpha
Brought to you by:
hdante
Menu
▾
▴
libposix-development — This list is for those who develop or are willing to develop libposix
You can subscribe to this list here.
| 2009 |
Jan
|
Feb
|
Mar
|
Apr
|
May
(16) |
Jun
(122) |
Jul
(49) |
Aug
(19) |
Sep
(6) |
Oct
(4) |
Nov
(1) |
Dec
|
|---|
|
From: Henrique A. <hd...@gm...> - 2009-07-15 00:44:46
|
It's not always true that -INT_MIN == INT_MAX. For example, in x86 INT_MIN == -2**31 and INT_MAX == 2**31-1. So that assertion is incorrect. I'll take a look at compiler provided includes for such values. There are a few include files that we can get a more complete implementation by looking at the compiler provided includes. 2009/7/9 Henrique Almeida <hd...@gm...>: > 2009/7/9 Henrique Almeida <hd...@gm...>: >> 2009/7/9 John Haitas <jh...@gm...>: >>> Henrique, >>> >>> Thanks for letting me know that. When do you expect to have a sprintf >>> implementation available? I will be able to use sprintf to test >> >> I can add it tomorrow. > > You can also use preprocessor tricks to stringify and alter the value > of limit macros. See __ASSERT_ITOA, for example > >> >>> against constants defined in <limits.h>. The stdlib_test I have >>> implemented is still very preliminary, meant mainly to test known >>> cases, I had planned to comment out tests that are known to fail. >> >> No need for commenting the tests. It's important that users know >> which functions are broken. >> >>> >>> Also, do you have support for the %f specifier in the printf() >>> function? Currently I am typecasting to a long and ignoring anything >> >> I wasn't planning to add that one soon, I don't know how hard it is. >> I can give you a better answer on the weekend. In general, dealing >> with floating point is hard because it varies with hardware and >> dealing with precision errors is very difficult. >> >>> after the radix (I need to implement the pow() function first anyway). >>> >>> Thanks for your hard work and suggestions for how I can improve my >>> contributions. >>> >>> Cheers, >>> John >>> >>> On Thu, Jul 9, 2009 at 6:14 PM, Henrique Almeida<hd...@gm...> wrote: >>>> Hello, >>>> >>>> The stdlib_test.c submitted has too few test coverage. Unit tests >>>> must have near full test coverage. Please refer to the wiki for the >>>> rules on how to write unit tests for libposix: >>>> >>>> https://sourceforge.net/apps/mediawiki/libposix/index.php?title=How_to_write_tests >>>> >>>> The missing coverage includes, non base 10, base 0, base > 10, >>>> testing for endptr, testing strings with garbage, testing endptr == >>>> NULL and testing out or range values (ex: try 256 bit integers). Don't >>>> worry that the current implementations fail the test. The functions >>>> may be developed gradually, but not the unit tests. Currently, >>>> TaskFreak seems to be broken, I'll add that task when it works, but >>>> start fixing that in the meantime. >>>> >>>> Remember to add a copyright line to CMakeLists.txt >>>> >>>> And thanks for the commit, off course. >>>> >>>> -- >>>> Henrique Dante de Almeida >>>> hd...@gm... >>>> >>> >>> >>> >>> -- >>> John Haitas >>> jh...@gm... >>> >> >> >> >> -- >> Henrique Dante de Almeida >> hd...@gm... >> > > > > -- > Henrique Dante de Almeida > hd...@gm... > -- Henrique Dante de Almeida hd...@gm... |
|
From: John H. <jh...@gm...> - 2009-07-12 19:05:18
|
Thanks Henrique! On Sun, Jul 12, 2009 at 11:14 AM, Henrique Almeida<hd...@gm...> wrote: > Added sprintf for those who needed it. > > 2009/7/1 Henrique Almeida <hd...@gm...>: >> Some integer and string outputs are working. The output of >> printf_parser should be: >> >> 511abcd abcdxyz >> e 4095 f g 0X2D i >> >> Please test. >> >> 2009/6/29 Henrique Almeida <hd...@gm...>: >>> It could be used in the short term, but alloca is not present in the >>> standard. According to glibc docs, it's a BSD extension. >>> >>> 2009/6/28 Chris Forbes <ch...@fa...>: >>>> Henrique: >>>> >>>>> require a working malloc implementation >>>> >>>> I assume you'd be able to allocate that stuff locally in your own stack >>>> frame with alloca(), in lieu of having a real allocator? >>>> >>>> -- Chris >>>> >>>> -----Original Message----- >>>> From: Henrique Almeida [mailto:hd...@gm...] >>>> Sent: Monday, 29 June 2009 12:14 p.m. >>>> To: lib...@li... >>>> Subject: Re: [libposix-development] printf parser >>>> >>>> We have to make them too. Lots of them. While printf is not ready, >>>> the two programs cited are unit tests for the parser and scanner. I've >>>> put them in the "tests/internal" directory since they are >>>> implementation details. Also we're missing support for tests in our >>>> CMakeLists.txt (ie "make test"). After that the CMake build will be >>>> complete. >>>> >>>> 2009/6/28 Kirill A. Shutemov <ki...@sh...>: >>>>> On Sun, Jun 28, 2009 at 6:41 PM, Henrique Almeida<hd...@gm...> wrote: >>>>>> I'm approaching a complete printf implementation, and I've just >>>>>> updated a printf parser to the repository, which is already in an >>>>>> advanced state. It's able to parse non trivial strings, like "e %-2ld >>>>>> f %0#'133.45Lg g %+.hhX i\n". The actual output functions >>>>>> (output_unsigned, output_double, etc.) are still missing, so it >>>>>> doesn't print anything yet, but I'll start writing those soon. Also >>>>>> missing are dealing with "numbered arguments" (things like "%2$d %1$s >>>>>> %3$g", they allow out of order argument passing), which are harder and >>>>>> require a working malloc implementation. >>>>>> >>>>>> Please run the tests "printf_parser" and "printf_scanner" and check >>>>>> that they don't crash or give weird results. printf_scanner should >>>>>> return zero and printf_parser should have the following result at the >>>>>> moment: >>>>>> >>>>>> abcd >>>>>> e f g i >>>>>> >>>>>> I expect to finish this until the middle of the week, so that we have >>>>>> a nearly complete printf. >>>>> >>>>> What about unit tests? >>>>> >>>>> ------------------------------------------------------------------------------ >>>>> _______________________________________________ >>>>> Libposix-development mailing list >>>>> Lib...@li... >>>>> https://lists.sourceforge.net/lists/listinfo/libposix-development >>>>> >>>> >>>> >>>> >>>> -- >>>> Henrique Dante de Almeida >>>> hd...@gm... >>>> >>>> ------------------------------------------------------------------------------ >>>> _______________________________________________ >>>> Libposix-development mailing list >>>> Lib...@li... >>>> https://lists.sourceforge.net/lists/listinfo/libposix-development >>>> ------------------------------------------------------------------------------ >>>> _______________________________________________ >>>> Libposix-development mailing list >>>> Lib...@li... >>>> https://lists.sourceforge.net/lists/listinfo/libposix-development >>>> >>> >>> >>> >>> -- >>> Henrique Dante de Almeida >>> hd...@gm... >>> >> >> >> >> -- >> Henrique Dante de Almeida >> hd...@gm... >> > > > > -- > Henrique Dante de Almeida > hd...@gm... > > ------------------------------------------------------------------------------ > Enter the BlackBerry Developer Challenge > This is your chance to win up to $100,000 in prizes! For a limited time, > vendors submitting new applications to BlackBerry App World(TM) will have > the opportunity to enter the BlackBerry Developer Challenge. See full prize > details at: http://p.sf.net/sfu/Challenge > _______________________________________________ > Libposix-development mailing list > Lib...@li... > https://lists.sourceforge.net/lists/listinfo/libposix-development > -- John Haitas jh...@gm... |
|
From: Henrique A. <hd...@gm...> - 2009-07-12 16:16:17
|
I've added a macro, available to the build system to add tests: add_libposix_test(test_name source1 source2 ...) CMakeLists.txt now can add tests with a single line rule. 2009/7/8 Henrique Almeida <hd...@gm...>: > 2009/7/4 Henrique Almeida <hd...@gm...>: >> >> I'll add an article in the wiki explaining the recommended way to >> write tests for libposix. > > A small guide to writing tests for libposix is now available at: > > https://sourceforge.net/apps/mediawiki/libposix/index.php?title=How_to_write_tests > >> >> Henrique Dante de Almeida >> hd...@gm... >> > > > > -- > Henrique Dante de Almeida > hd...@gm... > -- Henrique Dante de Almeida hd...@gm... |
|
From: Henrique A. <hd...@gm...> - 2009-07-12 16:14:48
|
Added sprintf for those who needed it. 2009/7/1 Henrique Almeida <hd...@gm...>: > Some integer and string outputs are working. The output of > printf_parser should be: > > 511abcd abcdxyz > e 4095 f g 0X2D i > > Please test. > > 2009/6/29 Henrique Almeida <hd...@gm...>: >> It could be used in the short term, but alloca is not present in the >> standard. According to glibc docs, it's a BSD extension. >> >> 2009/6/28 Chris Forbes <ch...@fa...>: >>> Henrique: >>> >>>> require a working malloc implementation >>> >>> I assume you'd be able to allocate that stuff locally in your own stack >>> frame with alloca(), in lieu of having a real allocator? >>> >>> -- Chris >>> >>> -----Original Message----- >>> From: Henrique Almeida [mailto:hd...@gm...] >>> Sent: Monday, 29 June 2009 12:14 p.m. >>> To: lib...@li... >>> Subject: Re: [libposix-development] printf parser >>> >>> We have to make them too. Lots of them. While printf is not ready, >>> the two programs cited are unit tests for the parser and scanner. I've >>> put them in the "tests/internal" directory since they are >>> implementation details. Also we're missing support for tests in our >>> CMakeLists.txt (ie "make test"). After that the CMake build will be >>> complete. >>> >>> 2009/6/28 Kirill A. Shutemov <ki...@sh...>: >>>> On Sun, Jun 28, 2009 at 6:41 PM, Henrique Almeida<hd...@gm...> wrote: >>>>> I'm approaching a complete printf implementation, and I've just >>>>> updated a printf parser to the repository, which is already in an >>>>> advanced state. It's able to parse non trivial strings, like "e %-2ld >>>>> f %0#'133.45Lg g %+.hhX i\n". The actual output functions >>>>> (output_unsigned, output_double, etc.) are still missing, so it >>>>> doesn't print anything yet, but I'll start writing those soon. Also >>>>> missing are dealing with "numbered arguments" (things like "%2$d %1$s >>>>> %3$g", they allow out of order argument passing), which are harder and >>>>> require a working malloc implementation. >>>>> >>>>> Please run the tests "printf_parser" and "printf_scanner" and check >>>>> that they don't crash or give weird results. printf_scanner should >>>>> return zero and printf_parser should have the following result at the >>>>> moment: >>>>> >>>>> abcd >>>>> e f g i >>>>> >>>>> I expect to finish this until the middle of the week, so that we have >>>>> a nearly complete printf. >>>> >>>> What about unit tests? >>>> >>>> ------------------------------------------------------------------------------ >>>> _______________________________________________ >>>> Libposix-development mailing list >>>> Lib...@li... >>>> https://lists.sourceforge.net/lists/listinfo/libposix-development >>>> >>> >>> >>> >>> -- >>> Henrique Dante de Almeida >>> hd...@gm... >>> >>> ------------------------------------------------------------------------------ >>> _______________________________________________ >>> Libposix-development mailing list >>> Lib...@li... >>> https://lists.sourceforge.net/lists/listinfo/libposix-development >>> ------------------------------------------------------------------------------ >>> _______________________________________________ >>> Libposix-development mailing list >>> Lib...@li... >>> https://lists.sourceforge.net/lists/listinfo/libposix-development >>> >> >> >> >> -- >> Henrique Dante de Almeida >> hd...@gm... >> > > > > -- > Henrique Dante de Almeida > hd...@gm... > -- Henrique Dante de Almeida hd...@gm... |
|
From: Henrique A. <hd...@gm...> - 2009-07-09 23:15:01
|
Hello, The stdlib_test.c submitted has too few test coverage. Unit tests must have near full test coverage. Please refer to the wiki for the rules on how to write unit tests for libposix: https://sourceforge.net/apps/mediawiki/libposix/index.php?title=How_to_write_tests The missing coverage includes, non base 10, base 0, base > 10, testing for endptr, testing strings with garbage, testing endptr == NULL and testing out or range values (ex: try 256 bit integers). Don't worry that the current implementations fail the test. The functions may be developed gradually, but not the unit tests. Currently, TaskFreak seems to be broken, I'll add that task when it works, but start fixing that in the meantime. Remember to add a copyright line to CMakeLists.txt And thanks for the commit, off course. -- Henrique Dante de Almeida hd...@gm... |
|
From: Henrique A. <hd...@gm...> - 2009-07-08 19:12:26
|
2009/7/4 Henrique Almeida <hd...@gm...>: > > I'll add an article in the wiki explaining the recommended way to > write tests for libposix. A small guide to writing tests for libposix is now available at: https://sourceforge.net/apps/mediawiki/libposix/index.php?title=How_to_write_tests > > Henrique Dante de Almeida > hd...@gm... > -- Henrique Dante de Almeida hd...@gm... |
|
From: Henrique A. <hd...@gm...> - 2009-07-08 04:23:53
|
2009/7/2 Henrique Almeida <hd...@gm...>: > I've uploaded an initial printf implementation that can format the > following arguments: > > - all variations of integer formats, except for arguments that use > both zero-padding and thousand grouping separators (it's easy to > implement, but it'll be useful only when we start dealing with > locales) > - "%s" I've completed the implementation for string output, including support for wide characters on POSIX locale. This week, I'll begin to work on bzip2 features. > > Later, I'll add tests for integer formats and finish dealing with > string arguments. If you're interested in testing, please write your > own tests too. > > -- > Henrique Dante de Almeida > hd...@gm... > -- Henrique Dante de Almeida hd...@gm... |
|
From: Henrique A. <hd...@gm...> - 2009-07-04 14:27:52
|
2009/7/4 Tordek <ke...@gm...>: > > There is an error on the test on the definition of r; r[6] == 0, but > it's compared to d[6], which is 'g'. The assertion on line 123 shows > this to be the case, and the strncpy on 125 doesn't touch it. > > Also, on line 101, assert(c+40 == strncpy(c+40, b, 40)); seems > wrong; should't it be b+40? Yes, both were wrong. > > Fixing those errors on the test do leave the error on copying empty > strings, which should be fixed by the patch. Passes all tests on my > machine, please check. Passed here too. The patch was applied. > > P.S.: Lovely printf, helped me track down the buggers ;P Are you using printf do debug ? :-) If you need a debugger, CMake has support for automatically adding debug symbols in the targets. Run ccmake and set CMAKE_BUILD_TYPE to Debug. Then you can use a debug with the test applications. I'll add that flag to the installation instructions. I'm currently using insight, but it's not working perfectly, I'm thinking about testing nemiver. http://projects.gnome.org/nemiver/ > > -- > Guillermo O. «Tordek» Freschi. Programador, Escritor, Genio Maligno. > http://tordek.com.ar :: http://twitter.com/tordek > http://www.arcanopedia.com.ar - Juegos de Rol en Argentina > > ------------------------------------------------------------------------------ > > _______________________________________________ > Libposix-development mailing list > Lib...@li... > https://lists.sourceforge.net/lists/listinfo/libposix-development > > -- Henrique Dante de Almeida hd...@gm... |
|
From: Tordek <ke...@gm...> - 2009-07-04 11:51:14
|
Henrique Almeida wrote: > I've applied the patch and added those tests for a reference of a > more complete coverage. Note that with the improved coverage, an out > of bounds error was found: > > Assertion failed in file > /home/hdante/código/libposix/libposix/tests/strncpy.c, function main, > line 128: d[i] == r[i] > > So, remember to fix that bug in the strncpy implementation. There is an error on the test on the definition of r; r[6] == 0, but it's compared to d[6], which is 'g'. The assertion on line 123 shows this to be the case, and the strncpy on 125 doesn't touch it. Also, on line 101, assert(c+40 == strncpy(c+40, b, 40)); seems wrong; should't it be b+40? Fixing those errors on the test do leave the error on copying empty strings, which should be fixed by the patch. Passes all tests on my machine, please check. P.S.: Lovely printf, helped me track down the buggers ;P -- Guillermo O. «Tordek» Freschi. Programador, Escritor, Genio Maligno. http://tordek.com.ar :: http://twitter.com/tordek http://www.arcanopedia.com.ar - Juegos de Rol en Argentina |
|
From: Henrique A. <hd...@gm...> - 2009-07-04 04:21:39
|
I have reviewed the tests and the problem is that there's not enough coverage. Whenever the functions are easy to implement, a single file is enough to cover all tests we could possibly do for the function. In the case, there were missing tests for out of bounds overwriting, some border cases, like zero or one length strings, testing strncpy return value and copies of strings that are more general, like binary strings. The problem with partial tests is that they give the false sense that the code is conformant. If the function were more complicated, multiple tests could be made, so that the implementation gradually passed the tests. It's not a problem if the functions don't pass the tests. Actually, tests can be made before the functions. I've applied the patch and added those tests for a reference of a more complete coverage. Note that with the improved coverage, an out of bounds error was found: Assertion failed in file /home/hdante/código/libposix/libposix/tests/strncpy.c, function main, line 128: d[i] == r[i] So, remember to fix that bug in the strncpy implementation. I'll add an article in the wiki explaining the recommended way to write tests for libposix. 2009/7/1 Henrique Almeida <hd...@gm...>: > 2009/6/30 Tordek <ke...@gm...>: >> Henrique Almeida wrote: >>> Hello. :-) Thanks for the patch. The test file is missing (also it >>> can go in the "tests" directory, strncpy is a standard function). >> >> Heh, I was bound to miss something in my first patch :P. >> >> I'll get cracking writing tests, I guess. There's a trivial version >> of assert in the test file. >> >> (BTW, what's the proper way to send patches? Attachments ok?) > > Attachments are ok. I just need to review the coverage for the > strncpy test, then I'll merge it. I'll also write recomendations for > tests in libposix. > >> >> -- >> Guillermo O. «Tordek» Freschi. Programador, Escritor, Genio Maligno. >> http://tordek.com.ar :: http://twitter.com/tordek >> http://www.arcanopedia.com.ar - Juegos de Rol en Argentina >> >> ------------------------------------------------------------------------------ >> >> _______________________________________________ >> Libposix-development mailing list >> Lib...@li... >> https://lists.sourceforge.net/lists/listinfo/libposix-development >> >> > > > > -- > Henrique Dante de Almeida > hd...@gm... > -- Henrique Dante de Almeida hd...@gm... |
|
From: Henrique A. <hd...@gm...> - 2009-07-02 17:26:26
|
I've uploaded an initial printf implementation that can format the following arguments: - all variations of integer formats, except for arguments that use both zero-padding and thousand grouping separators (it's easy to implement, but it'll be useful only when we start dealing with locales) - "%s" Later, I'll add tests for integer formats and finish dealing with string arguments. If you're interested in testing, please write your own tests too. -- Henrique Dante de Almeida hd...@gm... |
|
From: Henrique A. <hd...@gm...> - 2009-07-02 02:49:41
|
Some integer and string outputs are working. The output of printf_parser should be: 511abcd abcdxyz e 4095 f g 0X2D i Please test. 2009/6/29 Henrique Almeida <hd...@gm...>: > It could be used in the short term, but alloca is not present in the > standard. According to glibc docs, it's a BSD extension. > > 2009/6/28 Chris Forbes <ch...@fa...>: >> Henrique: >> >>> require a working malloc implementation >> >> I assume you'd be able to allocate that stuff locally in your own stack >> frame with alloca(), in lieu of having a real allocator? >> >> -- Chris >> >> -----Original Message----- >> From: Henrique Almeida [mailto:hd...@gm...] >> Sent: Monday, 29 June 2009 12:14 p.m. >> To: lib...@li... >> Subject: Re: [libposix-development] printf parser >> >> We have to make them too. Lots of them. While printf is not ready, >> the two programs cited are unit tests for the parser and scanner. I've >> put them in the "tests/internal" directory since they are >> implementation details. Also we're missing support for tests in our >> CMakeLists.txt (ie "make test"). After that the CMake build will be >> complete. >> >> 2009/6/28 Kirill A. Shutemov <ki...@sh...>: >>> On Sun, Jun 28, 2009 at 6:41 PM, Henrique Almeida<hd...@gm...> wrote: >>>> I'm approaching a complete printf implementation, and I've just >>>> updated a printf parser to the repository, which is already in an >>>> advanced state. It's able to parse non trivial strings, like "e %-2ld >>>> f %0#'133.45Lg g %+.hhX i\n". The actual output functions >>>> (output_unsigned, output_double, etc.) are still missing, so it >>>> doesn't print anything yet, but I'll start writing those soon. Also >>>> missing are dealing with "numbered arguments" (things like "%2$d %1$s >>>> %3$g", they allow out of order argument passing), which are harder and >>>> require a working malloc implementation. >>>> >>>> Please run the tests "printf_parser" and "printf_scanner" and check >>>> that they don't crash or give weird results. printf_scanner should >>>> return zero and printf_parser should have the following result at the >>>> moment: >>>> >>>> abcd >>>> e f g i >>>> >>>> I expect to finish this until the middle of the week, so that we have >>>> a nearly complete printf. >>> >>> What about unit tests? >>> >>> ------------------------------------------------------------------------------ >>> _______________________________________________ >>> Libposix-development mailing list >>> Lib...@li... >>> https://lists.sourceforge.net/lists/listinfo/libposix-development >>> >> >> >> >> -- >> Henrique Dante de Almeida >> hd...@gm... >> >> ------------------------------------------------------------------------------ >> _______________________________________________ >> Libposix-development mailing list >> Lib...@li... >> https://lists.sourceforge.net/lists/listinfo/libposix-development >> ------------------------------------------------------------------------------ >> _______________________________________________ >> Libposix-development mailing list >> Lib...@li... >> https://lists.sourceforge.net/lists/listinfo/libposix-development >> > > > > -- > Henrique Dante de Almeida > hd...@gm... > -- Henrique Dante de Almeida hd...@gm... |
|
From: Tordek <ke...@gm...> - 2009-07-01 22:51:51
|
Henrique Almeida wrote: > 2009/7/1 Tordek <ke...@gm...>: >> Henrique Almeida wrote: >>> Yes, I don't think that SF login is integrated with SF apps yet. >> >> Oddly, both on the wiki and the phpbb forum, I'm logged in. Could >> you please try adding a tordek_ar user on taskfreak? > > Done. > OK, then, that fixed it: we need to create an user with the same username as our sf account name. -- Guillermo O. «Tordek» Freschi. Programador, Escritor, Genio Maligno. http://tordek.com.ar :: http://twitter.com/tordek http://www.arcanopedia.com.ar - Juegos de Rol en Argentina |
|
From: Henrique A. <hd...@gm...> - 2009-07-01 22:49:23
|
2009/7/1 Tordek <ke...@gm...>: > Henrique Almeida wrote: >> Yes, I don't think that SF login is integrated with SF apps yet. > > Oddly, both on the wiki and the phpbb forum, I'm logged in. Could > you please try adding a tordek_ar user on taskfreak? Done. > > > -- > Guillermo O. «Tordek» Freschi. Programador, Escritor, Genio Maligno. > http://tordek.com.ar :: http://twitter.com/tordek > http://www.arcanopedia.com.ar - Juegos de Rol en Argentina > > > ------------------------------------------------------------------------------ > > _______________________________________________ > Libposix-development mailing list > Lib...@li... > https://lists.sourceforge.net/lists/listinfo/libposix-development > > -- Henrique Dante de Almeida hd...@gm... |
|
From: Tordek <ke...@gm...> - 2009-07-01 22:31:08
|
Henrique Almeida wrote: > Yes, I don't think that SF login is integrated with SF apps yet. Oddly, both on the wiki and the phpbb forum, I'm logged in. Could you please try adding a tordek_ar user on taskfreak? -- Guillermo O. «Tordek» Freschi. Programador, Escritor, Genio Maligno. http://tordek.com.ar :: http://twitter.com/tordek http://www.arcanopedia.com.ar - Juegos de Rol en Argentina |
|
From: Henrique A. <hd...@gm...> - 2009-07-01 22:09:24
|
2009/7/1 Tordek <ke...@gm...>: > Henrique Almeida wrote: >> Actually, to view the notes, I think you'll need to be logged and >> access this page: >> >> https://sourceforge.net/apps/taskfreak/libposix/ >> > > I, for one, can't access that page: "Login Failed: username not found" Yes, I don't think that SF login is integrated with SF apps yet. I think I'll need to create logins for everyone. I've created a login for you, "tordek". > > > -- > Guillermo O. «Tordek» Freschi. Programador, Escritor, Genio Maligno. > http://tordek.com.ar :: http://twitter.com/tordek > http://www.arcanopedia.com.ar - Juegos de Rol en Argentina > > > ------------------------------------------------------------------------------ > > _______________________________________________ > Libposix-development mailing list > Lib...@li... > https://lists.sourceforge.net/lists/listinfo/libposix-development > > -- Henrique Dante de Almeida hd...@gm... |
|
From: Tordek <ke...@gm...> - 2009-07-01 21:58:01
|
Henrique Almeida wrote: > Actually, to view the notes, I think you'll need to be logged and > access this page: > > https://sourceforge.net/apps/taskfreak/libposix/ > I, for one, can't access that page: "Login Failed: username not found" -- Guillermo O. «Tordek» Freschi. Programador, Escritor, Genio Maligno. http://tordek.com.ar :: http://twitter.com/tordek http://www.arcanopedia.com.ar - Juegos de Rol en Argentina |
|
From: Henrique A. <hd...@gm...> - 2009-07-01 21:56:41
|
Actually, to view the notes, I think you'll need to be logged and access this page: https://sourceforge.net/apps/taskfreak/libposix/ BTW, I'm rather upset with SF migrating to those apps. They don't have the greatest quality in the world. 2009/7/1 Henrique Almeida <hd...@gm...>: > I'll start updating the task page with all the tasks we have. I'll > add things there on demand, or whenever I remember there's a task to > do. Remember to take a look on the pending tasks frequently. > > http://apps.sourceforge.net/taskfreak/libposix/public.php > > -- > Henrique Dante de Almeida > hd...@gm... > -- Henrique Dante de Almeida hd...@gm... |
|
From: Henrique A. <hd...@gm...> - 2009-07-01 20:55:41
|
2009/6/30 Tordek <ke...@gm...>: > Henrique Almeida wrote: >> Hello. :-) Thanks for the patch. The test file is missing (also it >> can go in the "tests" directory, strncpy is a standard function). > > Heh, I was bound to miss something in my first patch :P. > > I'll get cracking writing tests, I guess. There's a trivial version > of assert in the test file. > > (BTW, what's the proper way to send patches? Attachments ok?) Attachments are ok. I just need to review the coverage for the strncpy test, then I'll merge it. I'll also write recomendations for tests in libposix. > > -- > Guillermo O. «Tordek» Freschi. Programador, Escritor, Genio Maligno. > http://tordek.com.ar :: http://twitter.com/tordek > http://www.arcanopedia.com.ar - Juegos de Rol en Argentina > > ------------------------------------------------------------------------------ > > _______________________________________________ > Libposix-development mailing list > Lib...@li... > https://lists.sourceforge.net/lists/listinfo/libposix-development > > -- Henrique Dante de Almeida hd...@gm... |
|
From: Henrique A. <hd...@gm...> - 2009-07-01 19:04:57
|
I'll start updating the task page with all the tasks we have. I'll add things there on demand, or whenever I remember there's a task to do. Remember to take a look on the pending tasks frequently. http://apps.sourceforge.net/taskfreak/libposix/public.php -- Henrique Dante de Almeida hd...@gm... |
|
From: Henrique A. <hd...@gm...> - 2009-07-01 14:26:00
|
Applied and improved. 2009/7/1 Tordek <ke...@gm...>: > Henrique Almeida wrote: >> Thanks for the patch. However, I was unable to apply it because of >> the e-mail formatting. >> >> Applying: Assert.h, assert macro >> fatal: corrupt patch at line 19 >> Patch failed at 0001. > > I really need to learn to use mutt... > > Attached. > > -- > Guillermo O. «Tordek» Freschi. Programador, Escritor, Genio Maligno. > http://tordek.com.ar :: http://twitter.com/tordek > http://www.arcanopedia.com.ar - Juegos de Rol en Argentina > > ------------------------------------------------------------------------------ > > _______________________________________________ > Libposix-development mailing list > Lib...@li... > https://lists.sourceforge.net/lists/listinfo/libposix-development > > -- Henrique Dante de Almeida hd...@gm... |
|
From: Kirill A. S. <ki...@sh...> - 2009-07-01 07:11:13
|
On Wed, Jul 1, 2009 at 5:10 AM, Henrique Almeida<hd...@gm...> wrote: > Were you able to solve this issue ? Yep. It's local problem. |
|
From: Tordek <ke...@gm...> - 2009-07-01 03:50:55
|
Henrique Almeida wrote: > Thanks for the patch. However, I was unable to apply it because of > the e-mail formatting. > > Applying: Assert.h, assert macro > fatal: corrupt patch at line 19 > Patch failed at 0001. I really need to learn to use mutt... Attached. -- Guillermo O. «Tordek» Freschi. Programador, Escritor, Genio Maligno. http://tordek.com.ar :: http://twitter.com/tordek http://www.arcanopedia.com.ar - Juegos de Rol en Argentina |
|
From: Henrique A. <hd...@gm...> - 2009-07-01 03:39:14
|
Thanks for the patch. However, I was unable to apply it because of
the e-mail formatting.
Applying: Assert.h, assert macro
fatal: corrupt patch at line 19
Patch failed at 0001.
Please resend the patch as an attachment.
2009/6/30 Tordek <ke...@gm...>:
> Signed-off-by: Guillermo O. Freschi <to...@to...>
> ---
> mandatory/include/assert.h | 51
> ++++++++++++++++++++++++++++++++++++++++++++
> 1 files changed, 51 insertions(+), 0 deletions(-)
> create mode 100644 mandatory/include/assert.h
>
> diff --git a/mandatory/include/assert.h b/mandatory/include/assert.h
> new file mode 100644
> index 0000000..20c0f8f
> --- /dev/null
> +++ b/mandatory/include/assert.h
> @@ -0,0 +1,51 @@
> +/*
> +Copyright (c) 2009, Guillermo Oscar Freschi
> +All rights reserved.
> +
> +Redistribution and use in source and binary forms, with or without
> +modification, are permitted provided that the following conditions
> are met:
> +
> + * Redistributions of source code must retain the above
> copyright notice,
> + this list of conditions and the following disclaimer.
> + * Redistributions in binary form must reproduce the above copyright
> + notice, this list of conditions and the following disclaimer
> in the
> + documentation and/or other materials provided with the
> distribution.
> +
> +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> "AS IS"
> +AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
> TO, THE
> +IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
> PURPOSE
> +ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR
> CONTRIBUTORS BE
> +LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
> +CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
> +SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR
> BUSINESS
> +INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
> +CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
> +ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
> OF THE
> +POSSIBILITY OF SUCH DAMAGE.
> +*/
> +
> +#ifndef _ASSERT_H_INCLUDED_
> +#define _ASSERT_H_INCLUDED_
> +
> +#ifdef NDEBUG
> +#define assert(ignore)((void) 0)
> +#else
> +
> +// Temporal hack to show line numbers. Should be removed when
> +// printf is fully functional.
> +#define _ITOA_(num) #num
> +#define _ITOA(num) _ITOA_(num)
> +
> +#define assert(assertion) \
> + do { \
> + if(!(assertion)) { \
> + puts("Assertion failed in file " __FILE__ ", "\
> + "line " _ITOA(__LINE__) ": "\
> + #assertion); \
> + _Exit(EXIT_FAILURE); \
> + } \
> + } while(0)
> +
> +#endif /* NDEBUG */
> +
> +#endif /* _ASSERT_H_INCLUDED_ */
> --
> 1.6.3.3
>
>
> --
> Guillermo O. «Tordek» Freschi. Programador, Escritor, Genio Maligno.
> http://tordek.com.ar :: http://twitter.com/tordek
> http://www.arcanopedia.com.ar - Juegos de Rol en Argentina
>
>
> ------------------------------------------------------------------------------
>
> _______________________________________________
> Libposix-development mailing list
> Lib...@li...
> https://lists.sourceforge.net/lists/listinfo/libposix-development
>
>
--
Henrique Dante de Almeida
hd...@gm...
|
|
From: Tordek <ke...@gm...> - 2009-07-01 03:31:52
|
Henrique Almeida wrote: > Hello. :-) Thanks for the patch. The test file is missing (also it > can go in the "tests" directory, strncpy is a standard function). Heh, I was bound to miss something in my first patch :P. I'll get cracking writing tests, I guess. There's a trivial version of assert in the test file. (BTW, what's the proper way to send patches? Attachments ok?) -- Guillermo O. «Tordek» Freschi. Programador, Escritor, Genio Maligno. http://tordek.com.ar :: http://twitter.com/tordek http://www.arcanopedia.com.ar - Juegos de Rol en Argentina |
