Re: [Libmtp-discuss] Handling of PTP_OPC_ObjectSize

[Philip L. <ph...@ov...>]

On Sun, 11 Mar 2018 18:47:35 +0100
Marcus Meissner <mei...@su...> wrote:

> On Fri, Mar 09, 2018 at 08:22:17PM -0800, Philip Langdale wrote:
> > On Fri, 9 Mar 2018 20:17:43 -0800
> > Philip Langdale <ph...@ov...> wrote:  
> > > 
> > > Secondarily: Nexus/Pixel devices are marked as
> > > DEVICE_FLAG_PROPLIST_OVERRIDES_OI, and so they take this code
> > > path, but it wasn't always so, and I wonder whether this flag
> > > should even be set these days.
> > > 
> > > Jerry, Lei - that's a question for you guys, I think.  
> > 
> > And, in fact, this flag is only applied to the MTP mode. In MTP+ADB
> > mode, the flag is not applied, and things work fine - so it's
> > clearly dubious.
> > 
> > Mind you, the file size is still being truncated to 4GB - so maybe
> > that's happening on the device side??  
> 
> Foremost issue is that I do not have such a device that allows
> files larger than 4GB so I can debug this all the way through.
> 
> I tried improving the >4GB support of both libmtp and libgphoto2
> but even my Samsung Galaxy S7 does not seem to support files larger
> than 4GB, neither do my modern DSLRs :(
> 
> Is the Nexus/Pixel really doing that?
> 
> Occasionaly the ObjectSize is used for reading, the 0xfffffff check
> could be moved to later usage places, and still exposed outside
> better.
> 
> Ciao, Marcus

I'm not sure if the mailing list is working right now, but I sent a
patch to fix the problem. The issue is that the Get_File calls don't
do the extended lookup to get the 64bit file size. So I just made that
small change and now we see reasonable results.

--phil