From: Roy S. <roy...@ic...> - 2006-03-29 05:58:29
|
On Tue, 28 Mar 2006, Benjamin S. Kirk wrote: > On Tue, 2006-03-28 at 07:43 -0600, Roy Stogner wrote: >> I'm not sure that should be a function argument, though. It looks to >> me as if the maintain_level_one code only works if the mesh is already >> level one compatible, in which case you're not going to be turning it >> on and off from refinement step to refinement step - perhaps it ought >> to be set in the MeshRefinement constructor instead. > > Excellent point. I have no problem making it an optional argument to > the constructor which defaults to true. Sounds good. I don't think I'm going to make any more small changes while I'm in the middle of this p refinement stuff, though; you've already had to fix one of my poor attempts to commit a changed file that wasn't in sync with my local sandbox. I think I'm ready to sync my current code to CVS now, actually. I'm having trouble thinking of a quick way to test adaptive p refinement (is there such a thing as a simple element-by-element way to decide between h and p refinement?), but our existing examples and my uniform p refinement tests are all working now. > You are correct, I never anticipated taking a non-level-1 conforming > mesh and restoring level-one-ness (or whatever you call it). It's always the unanticipated stuff that gets you. That's why I like this collaborative software development stuff; there's always someone else to catch your bugs if you don't! ;-) On that note, we probably ought to put a global tag on the CVS head before I do my next big commit. I don't think there's anything that should break any code which doesn't do p refinement, but it's a big change that touches a lot of files, and just in case people do start running into bugs it might be prudent to make reverting the whole changeset easy. Ben, would you mind doing that (and letting me know when it's safe to commit)? It's been a while since I've done anything with CVS tags; I'd hate to find out I'd accidentally started a new branch or something. --- Roy |