|
From: Roy S. <roy...@ic...> - 2016-10-19 14:40:17
|
On Wed, 19 Oct 2016, John Peterson wrote: > On Wed, Oct 19, 2016 at 7:19 AM, Roy Stogner <roy...@ic...> wrote: > > On Tue, 18 Oct 2016, Manav Bhatia wrote: > > Seems like this was added in “65cde6a” on 5/17/14. > Was this intended? > > Intended, but not correctly, I believe. It looks like John was going > through the code looking for switch statements with no default (which > > Nice try, Roy. You added that default case in fb94e262. Ha! Sorry; I just did a quick "git log 65cde6a"; wasn't trying to dodge blame. > Furthermore, "git log -p fb94e262 -- src/fe/fe_szabab_shape_2D.C" > shows that 10 similar default cases were added in the same commit, > so we probably want to remove all of them... Will do. I'll put up a PR soon. --- Roy |