From: John P. <jwp...@gm...> - 2012-05-30 21:02:25
|
On Wed, May 30, 2012 at 2:29 PM, Paul T. Bauman <ptb...@gm...> wrote: > > On Wed, May 30, 2012 at 3:23 PM, John Peterson <jwp...@gm...> wrote: >> >> Here's one error: >> >> /Users/petejw/projects/libmesh_git/include/fe/fe_base.h: In >> constructor ‘libMesh::FEBase::FEBase(unsigned int, const >> libMesh::FEType&)’: >> /Users/petejw/projects/libmesh_git/include/fe/fe_base.h:593: error: >> expected identifier before ‘{’ token >> /Users/petejw/projects/libmesh_git/include/fe/fe_base.h:593: error: >> expected `(' before ‘{’ token >> >> I do not have LIBMESH_ENABLE_INFINITE_ELEMENTS defined, so this >> constructor list has a trailing comma? > > > That's what I get for trying with --enable-everything. Here's a patch for > fe_base.h (against trunk) that should fix that. Your second patch isn't really a great fix, since technically things should be initialized in the constructor in the order they are declared in the class, but, thinking about it for a moment, this constructor is just oddly-written in general: there's not really any need to call all these vector default constructors explicitly. Probably just really old code I'm guessing...should be fine to just delete all of those guys. Anyway, all our tests seem to pass here. -- John |