mistake in udev rules
Brought to you by:
mr_brain
Menu
▾
▴
#5 mistake in udev rules
There appears to be a mistake in the udev rules with version 0.4.1, causing them to match ALL devices. Since the unnumbered velleman.rules rule will be read last, this results in all the devices in /dev being set to MODE="0660" and GROUP="k8055" including /dev/null and similar. This is most inconvenient !
(The same error was present ion 0.4.0, but the result was setting all devices on the system to MODE="0666" and GROUP="root" which not noticeable in everyday usage but was a security concern)
The line
SUBSYSTEM !="usb_device", ACTION !="add", GOTO="velleman_rules_end"
requires BOTH conditions to be true in order to execute the GOTO, not either.
Splitting into the separate lines:
SUBSYSTEM !="usb_device", GOTO="velleman_rules_end"
ACTION!="add", GOTO="velleman_rules_end"
# Probably redundant? :
ENV{DEVTYPE}!="usb_device", GOTO="velleman_rules_end"
fixes this.
Additionally, the unconditional line
MODE="0660", GROUP="k8055"
will surely execute for EVERY device NOT caught by the GOTO conditional even with the above correction (probably every USB device plugged in? I didn't check this)
They should be appended to each line matching the idVendor and idProduct keys e.g:
SYSFS{idVendor}=="10cf", SYSFS{idProduct}=="5500", SYMLINK+="k8055_0", MODE="0660", GROUP="k8055"
SYSFS{idVendor}=="10cf", SYSFS{idProduct}=="5501", SYMLINK+="k8055_1", MODE="0660", GROUP="k8055"
...
I'm afraid I don 't know how to submit a proper patch but a corrected version of velleman.rules is attached
my verision of velleman.rules