libirc-devel

[Libirc-devel] PONG bug

[<bf...@li...>]

Hi,
 I have problem with connecting to Unreal IRC server. I would like to 
suppose the following patch:

Have a nice day,
 Barna Faragó.

Index: src/ircBasicCommands.cpp
===================================================================
RCS file: /cvsroot/libirc/libirc/src/ircBasicCommands.cpp,v
retrieving revision 1.17
diff -u -r1.17 ircBasicCommands.cpp
--- src/ircBasicCommands.cpp 12 Mar 2005 22:47:35 -0000 1.17
+++ src/ircBasicCommands.cpp 5 Apr 2005 17:03:15 -0000
@@ -79,6 +79,7 @@
 {
  IRCCommandINfo ircInfo;
  ircInfo.command = eCMD_PONG;
+    ircInfo.raw=info.raw;
  client.sendIRCCommand(eCMD_PONG,ircInfo);
  return true;
 }
@@ -108,8 +109,8 @@
 bool IRCPongCommand::send ( IRCClient &client, std::string &command,
BaseIRCCommandInfo &info )
 {
  IRCCommandINfo &ircInfo = (IRCCommandINfo&)info;
-
- std::string commandLine;
+
+ std::string commandLine=info.raw.substr(5, info.raw.length()-5);
  // PING
  client.sendIRCCommandToServer(eCMD_PONG,commandLine);
  return true; 

Re: [Libirc-devel] PONG bug

[Christopher S. M. <br...@ma...>]

Barna,

Sorry for taking so utterly long to reply, but your patch has been =20
finally applied to the sources.  Thanks for the fix to the pong =20
reply!  I'd noticed the same problem, but it wasn't a critical error =20
with the networks we were working with.  I've credited you with the =20
fix in our doc files, thanks again.

Cheers!
Sean

On Apr 5, 2005, at 1:39 PM, Barna Farag=F3 wrote:

> Hi,
> I have problem with connecting to Unreal IRC server. I would like =20
> to suppose the following patch:
>
> Have a nice day,
> Barna Farag=F3.
>
> Index: src/ircBasicCommands.cpp
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: /cvsroot/libirc/libirc/src/ircBasicCommands.cpp,v
> retrieving revision 1.17
> diff -u -r1.17 ircBasicCommands.cpp
> --- src/ircBasicCommands.cpp 12 Mar 2005 22:47:35 -0000 1.17
> +++ src/ircBasicCommands.cpp 5 Apr 2005 17:03:15 -0000
> @@ -79,6 +79,7 @@
> {
>  IRCCommandINfo ircInfo;
>  ircInfo.command =3D eCMD_PONG;
> +    ircInfo.raw=3Dinfo.raw;
>  client.sendIRCCommand(eCMD_PONG,ircInfo);
>  return true;
> }
> @@ -108,8 +109,8 @@
> bool IRCPongCommand::send ( IRCClient &client, std::string &command,
> BaseIRCCommandInfo &info )
> {
>  IRCCommandINfo &ircInfo =3D (IRCCommandINfo&)info;
> -
> - std::string commandLine;
> +
> + std::string commandLine=3Dinfo.raw.substr(5, info.raw.length()-5);
>  // PING
>  client.sendIRCCommandToServer(eCMD_PONG,commandLine);
>  return true;
>
>
> -------------------------------------------------------
> SF email is sponsored by - The IT Product Guide
> Read honest & candid reviews on hundreds of IT Products from real =20
> users.
> Discover which products truly live up to the hype. Start reading now.
> http://ads.osdn.com/?ad_id=3D6595&alloc_id=3D14396&op=3Dclick
> _______________________________________________
> Libirc-devel mailing list
> Lib...@li...
> https://lists.sourceforge.net/lists/listinfo/libirc-devel