[libexif-cvs] libexif/libexif/canon exif-mnote-data-canon.c,1.11,1.12

[Hans U. N. <hu...@us...>]

Update of /cvsroot/libexif/libexif/libexif/canon
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv21933

Modified Files:
	exif-mnote-data-canon.c 
Log Message:
Symptoms of bug #1054323 are fixed, but not the cause. Added FIXME notice about the cause.

Index: exif-mnote-data-canon.c
===================================================================
RCS file: /cvsroot/libexif/libexif/libexif/canon/exif-mnote-data-canon.c,v
retrieving revision 1.11
retrieving revision 1.12
diff -u -d -r1.11 -r1.12
--- exif-mnote-data-canon.c	9 Mar 2005 21:05:10 -0000	1.11
+++ exif-mnote-data-canon.c	22 Mar 2005 01:27:10 -0000	1.12
@@ -148,6 +148,18 @@
 	}
 }
 
+/* XXX
+ * FIXME: exif_mnote_data_canon_load() may fail and there is no
+ *        semantics to express that.
+ *        See bug #1054323 for details, especially the comment by liblit
+ *        after it has supposedly been fixed:
+ *
+ *        https://sourceforge.net/tracker/?func=detail&aid=1054323&group_id=12272&atid=112272
+ *        Unfortunately, the "return" statements aren't commented at
+ *        all, so it isn't trivial to find out what is a normal
+ *        return, and what is a reaction to an error condition.
+ */
+
 static void
 exif_mnote_data_canon_load (ExifMnoteData *ne,
 	const unsigned char *buf, unsigned int buf_size)