libexif-devel — This is the place where your questions about libexif will be answered.

Re: [Libexif-devel] [PATCH] doc/Makefile breaks when Doxygen is absent

[Hans U. N. <gp...@n-...>]

"Daniel Richard G." <sk...@iS...> writes:

> Was building KDE via the Konstruct framework, which builds libexif as a 
> dependency. The library build broke at the "make install" stage due to a 
> minor oversight in doc/Makefile.am:
>
> The install target depends on install-data-local (per standard Automake), 
> which depends on install-apidocs and install-apidocs-internals. But these 
> latter two targets do not exist if Doxygen was not detected at configure 
> time; an Automake conditional comments them out.
>
> The attached patch defines dummy targets for install-apidocs*, 
> uninstall-apidocs* and $(DOXYGEN_UPLOAD), that merely print warning 
> messages if invoked in the no-Doxygen case. (clean-apidocs is left 
> unconditionalized, since that can reasonably do the same thing always.)
>
> I'll be happy to follow up any issues with the patch.

I think I had that one fixed in CVS, but I'll verify again.

A new release is overdue anyway, and it will contain that fix.

Thanks for the report.

Uli

[Libexif-devel] [PATCH] doc/Makefile breaks when Doxygen is absent

[Daniel R. G. <sk...@iS...>]

Was building KDE via the Konstruct framework, which builds libexif as a 
dependency. The library build broke at the "make install" stage due to a 
minor oversight in doc/Makefile.am:

The install target depends on install-data-local (per standard Automake), 
which depends on install-apidocs and install-apidocs-internals. But these 
latter two targets do not exist if Doxygen was not detected at configure 
time; an Automake conditional comments them out.

The attached patch defines dummy targets for install-apidocs*, 
uninstall-apidocs* and $(DOXYGEN_UPLOAD), that merely print warning 
messages if invoked in the no-Doxygen case. (clean-apidocs is left 
unconditionalized, since that can reasonably do the same thing always.)

I'll be happy to follow up any issues with the patch.

(Please Cc me on any replies, as I am not subscribed to this list)


--Daniel


-- 
NAME   = Daniel Richard G.       ##  Remember, skunks       _\|/_  meef?
EMAIL1 = sk...@is...        ##  don't smell bad---    (/o|o\) /
EMAIL2 = sk...@al...      ##  it's the people who   < (^),>
WWW    = http://www.******.org/  ##  annoy them that do!    /   \
--
(****** = site not yet online)

Re: [Libexif-devel] VmlAGRA

[Ashok D. <lae...@ha...>]

Hi,

VmlAGRA for LESS http://www.xedinkiondeindades.com

=20
guess it must have been me.
Morning all. Good day for the expedition. Hi and unhappily good-by

[Libexif-devel] =?windows-874?q?=BF=C3=D5!_=AB=D7=E9=CD_=A2=D2=C2_=BB=C3=D0=AA=D2=CA=D1=C1=BE=D1=B9=B8=EC_=E0=BB=D4=B4=E3=CB=E9=BA=C3=D4=A1=D2=C3=E1=C5=E9=C7_?=

[wut <wut...@ya...>]

=A8=D0=AB=D7=E9=CD =A8=D0=A2=D2=C2 =BB=C3=D0=AA=D2=CA=D1=C1=BE=D1=B9=B8=EC =CB=
=D2=A7=D2=B9 =CB=D2=A4=B9 =E0=AA=D4=AD=E3=AA=E9=BA=C3=D4=A1=D2=C3=BF=C3=D5
http://www.e-marketingonline.net  

Re: [Libexif-devel] [libexif-cvs] libexif/libexif/olympus mnote-olympus-entry.c, 1.22, 1.23 mnote-olympus-tag.c, 1.9, 1.10 mnote-olympus-tag.h, 1.4, 1.5

[Marcus M. <ma...@je...>]

On Tue, Oct 03, 2006 at 04:13:00PM +0200, Joerg Hoh wrote:
> On Tue, Oct 03, 2006 at 01:49:24PM +0000, Marcus Meissner wrote:
> > +	case MNOTE_NIKON_TAG_EXPOSUREDIFF: {
> > +		unsigned char a,b,c,d;
> > +                CF (entry->format, EXIF_FORMAT_UNDEFINED, v, maxlen);
> > +                CC (entry->components, 4, v, maxlen);
> > +                vl =  exif_get_long (entry->data, entry->order);
> > +		a = (vl>>24)&0xff; b = (vl>>16)&0xff; c = (vl>>8)&0xff; d = (vl)&0xff;
> > +                snprintf (v, maxlen, "%.1f",  c?(float)a*((float)b/(float)c):0 );
> > +                break;
> > +	}
> > +	case MNOTE_NIKON_TAG_LENS_FSTOPS: {
> > +		unsigned char a,b,c,d;
> > +                CF (entry->format, EXIF_FORMAT_UNDEFINED, v, maxlen);
> > +                CC (entry->components, 4, v, maxlen);
> > +                vl =  exif_get_long (entry->data, entry->order);
> > +		a = (vl>>24)&0xff; b = (vl>>16)&0xff; c = (vl>>8)&0xff; d = (vl)&0xff;
> > +                snprintf (v, maxlen, "%.2f",  c?(float)a*((float)b/(float)c):0 );
> > +                break;
> > +	}
> 
> What's the difference in this 2 case statements? It looks pretty much like
> copy & paste code (see indentation). The only difference I found is the
> number of digits in the snprintf statement.

True. I have merged both cases.

Ciao, Marcus

Re: [Libexif-devel] [libexif-cvs] libexif/libexif/olympus mnote-olympus-entry.c, 1.22, 1.23 mnote-olympus-tag.c, 1.9, 1.10 mnote-olympus-tag.h, 1.4, 1.5

[Joerg H. <jo...@jo...>]

On Tue, Oct 03, 2006 at 01:49:24PM +0000, Marcus Meissner wrote:
> +	case MNOTE_NIKON_TAG_EXPOSUREDIFF: {
> +		unsigned char a,b,c,d;
> +                CF (entry->format, EXIF_FORMAT_UNDEFINED, v, maxlen);
> +                CC (entry->components, 4, v, maxlen);
> +                vl =3D  exif_get_long (entry->data, entry->order);
> +		a =3D (vl>>24)&0xff; b =3D (vl>>16)&0xff; c =3D (vl>>8)&0xff; d =3D (v=
l)&0xff;
> +                snprintf (v, maxlen, "%.1f",  c?(float)a*((float)b/(floa=
t)c):0 );
> +                break;
> +	}
> +	case MNOTE_NIKON_TAG_LENS_FSTOPS: {
> +		unsigned char a,b,c,d;
> +                CF (entry->format, EXIF_FORMAT_UNDEFINED, v, maxlen);
> +                CC (entry->components, 4, v, maxlen);
> +                vl =3D  exif_get_long (entry->data, entry->order);
> +		a =3D (vl>>24)&0xff; b =3D (vl>>16)&0xff; c =3D (vl>>8)&0xff; d =3D (v=
l)&0xff;
> +                snprintf (v, maxlen, "%.2f",  c?(float)a*((float)b/(floa=
t)c):0 );
> +                break;
> +	}

What's the difference in this 2 case statements? It looks pretty much like
copy & paste code (see indentation). The only difference I found is the
number of digits in the snprintf statement.

Joerg

--=20
What did you do to the cat? It looks half-dead. -Schroedinger's wife

[Libexif-devel] PHyzdARMA

[Nichola O. <ke...@hu...>]

Good day,

VALttIUM

VIAttGRA

CIAttLIS

AMBttIEN

Save 50 % with http://www.gadesunjinkertion.com
=20
  _____ =20


about you. See this ugly-looking type in the horned helmet? He is just
You talking about yourself? I queried, blade still ready.
admiration for the electronics in this place.

[Libexif-devel] 20.000 FUENTES Y LOGOS A 35 PESOS - ENVIO GRATIS ---Promocion---

[Informacion F. <fu...@ci...>]

MAS DE 20.000 FUENTES Y LOGOS DE UTILIDAD PARA DARLE PARA SU NEGOCIO O EMPRESA TOTALMENTE EDITABLES
LA MEJOR IMAGEN A TU NEGOCIO O TRABAJO
TODAS LAS FUENTES ACTUALIZADA 2006
EXCLUSIVA DE  FUENTES Y LOGOS

EL CD A SOLO 35.00 PESOS ENVIO GRATIS DENTRO DE CAPITAL FEDERAL

EL ENVIO ES GRATIS SOLO DENTRO DE CAP.FED

EL ENVIO FUERA DE CAP.FED SALE DE 15 A 20 PESOS

EL ENVIO PARA OTROS PAISES SALE 10 DOLARES


NUESTRO SITIO WEB:  WWW.DEFUENTES.COM

CONTACTO A:
con...@de...

-----------------------------------------------------------------------------------------------------------------------------------------

SI DESEA SALIR DE ESTA LISTA RESPONDA EL MENSAJE CON EL SUJETO(SUBJET) REMOVER

[Libexif-devel] Vea ahora mas de 700 Canales de TV en su PC por solo 25 pesos - Promocion --- 22

[Rocio V. <tvc...@pi...>]

  DEPORTES,VIDEOS MUSICALES, NOTICIEROS,CARICATURAS, PELICULAS DE TODO TIPO (AAA - XXX)

 CANALES PARA LA MUJER ASI PODES VER EL FUTBOL TRANQUILO!

 DE TODAS PARTES DEL MUNDO EN VIVO

 POR SOLO 25 PESOS POR UNICA VEZ

 SOLO NECESITAS UNA CONEXION A INTERNET PARA VER LOS CANALES

 EL ENVIO  DEL CD CON TODOS LOS ACCESORIOS DENTRO A  DE CAPITAL FEDERAL(ARGENTINA) ES GRATIS

 EL ENVIO FUERA DE ESA ZONA ES VIA ONLINE Y USTED LO BAJA DESDE NUESTROS SERVIDORES

 NUESTRO SITIO WEB:

 WWW.SOLOPRODUCTOS.COM


 CONTACTO A: con...@so...


 FORMAS DE PAGO:

 DENTRO DE CAPITAL FEDERAL(ARGENTINA): CONTRAREEMBOLSO(LO PAGA CUANDO LO RECIBE)
 FUERA DE CAPITAL FEDERAL O EN EL EXTERIOR:  PAGO PACIL, PAYPAL.
 --------------------------------------------------------------------------------------------------------------------------------------------------------------------------


SI DESEA SALIR DE ESTA LISTA RESPONDA ESTE MENSAJE CON EL SUJETO(SUBJET) REMOVER

AAAReeEEEE-RR22

Re: [Libexif-devel] Need some help with adding support for extra canon makernotes

[Lutz <lu...@to...>]

On Tue, 2006-09-12 at 20:45 +0200, Jef Driesen wrote:
> See attachment for the patch!

Applied. Thank you for your work!
--=20
Lutz M=FCller <lu...@to...>

Re: [Libexif-devel] Need some help with adding support for extra canon makernotes

[Jef D. <jef...@ho...>]

Hubert Figuiere wrote:
> On Tuesday 12 September 2006 09:35, Jef Driesen wrote:
>> I finished updating the libexif library with canon makernotes. I have
>> created three patches (mnote-canon-tag.h, mnote-canon-tag.c and
>> mnote-canon-entry.c) against the cvs version. How do I contribute this
>> work?
> 
> cvd diff -u to the mailing list, as "attachment"

See attachment for the patch!

Re: [Libexif-devel] Need some help with adding support for extra canon makernotes

[Hubert F. <hu...@fi...>]

On Tuesday 12 September 2006 09:35, Jef Driesen wrote:
> I finished updating the libexif library with canon makernotes. I have
> created three patches (mnote-canon-tag.h, mnote-canon-tag.c and
> mnote-canon-entry.c) against the cvs version. How do I contribute this
> work?

cvd diff -u to the mailing list, as "attachment"


Hub

Re: [Libexif-devel] Need some help with adding support for extra canon makernotes

[Jef D. <jef...@ho...>]

Jef Driesen wrote:
> Many makernote tags are already documented by the 'exiftool' project 
> [1], but are not in the libexif library. I'm working on adding those 
> canon makernotes to the libexif library.
> 
> [1] http://www.sno.phy.queensu.ca/~phil/exiftool/TagNames/Canon.html

I finished updating the libexif library with canon makernotes. I have 
created three patches (mnote-canon-tag.h, mnote-canon-tag.c and 
mnote-canon-entry.c) against the cvs version. How do I contribute this work?

An overview of the changes:

* Some tags were updated from exiftool:
    - MNOTE_CANON_TAG_SETTINGS_1
    - MNOTE_CANON_TAG_SETTINGS_2
I also intended to change there names to some more meaningful values, 
like used in exiftool (respectively CAMERA_SETTINGS and SHOT_INFO), but 
I'm not sure if that will break existing applications. The only tag I 
did not update is the lenstype.

* Some new tags were added from exiftool:
    - MNOTE_CANON_TAG_FOCAL_LENGTH
    - MNOTE_CANON_TAG_PANORAMA

* All other tags (documented or not by exiftool) do not contain very 
useful information (for the only camera I own), and were not added. 
Maybe later, who knows...

* Added some internal functions to convert apex values to 
aperture/shutterspeed/iso values. Also moved the code for the table 
lookups to separate functions.

* Added a "Manual flash output" tag (actually there are two), obtained 
by reverse engineering. It works for my camera, but I don't know for others!

For some tags, exiftool lists exceptions for specific type of camera's. 
I did not incorporate that information, because I don't have those 
camera's to test. I checked everything very carefully, but there could 
still be some mistakes...

[Libexif-devel] Football Season Starting..

[Scott S. <mai...@fp...>]

Are you looking for a better way of life?

Are you frustrated with working everyday for someone else on their schedule
just to break even?

Would you like to make ten to twenty five thousand or more a month?

People spend money everyday online.

You can now be the house just like Vegas or Atlantic City without the
liability.

Profit from the 15 billion per year industry for yourself.

Be the head honcho of your own organization and stop making someone else
wealthy.

Football Season is starting up, how many fantasy football fans you know
looking to make a wager?

Just reply and state MORE INFO as your subject.  Leave your phone number
and we will respond with additional information.

Or feel free to call us directly at 1-954-427-3460 (ask for extension 7).

Re: [Libexif-devel] Need some help with adding support for extra canon makernotes

[Jef D. <jef...@ho...>]

Jan Patera wrote:
>> Marcus Meissner wrote:
>>> On Wed, Sep 06, 2006 at 03:39:30PM +0200, Jef Driesen wrote:
>>>> Jan Patera wrote:
>>>>>> case MNOTE_CANON_TAG_FOCAL_LENGTH:
>>>>>>     CF (entry->format, EXIF_FORMAT_SHORT, val, maxlen);
>>>>>>     n = exif_get_short (data, entry->order) / 2;
>>>>>>     if (t >= n) return NULL;
>>>>>>     CC (entry->components, n, val, maxlen);
>>>>>>     vs = exif_get_short (entry->data + 2 + t * 2, entry->order);
>>>>>> snprintf (buf, sizeof (buf), "0x%04x", vs);
>>>>>>     strncpy (val, buf, maxlen - strlen (val));
>>>>>>     break;
>>>>>>
>>>>>> But when I run the exif commandline utility, an error is reported
>>>>>> for the new tag:
>>>>>>
>>>>>> Focal type          |Invalid number of components (4, expected 1).
>>>>>>
>>>>>> What am I doing wrong here?
>>>>> this message is printed by the CC macro. It checks whether
>>>>> 1st & 2nd arguments are equal. apparently entry->components is 4,
>>>>> but n is only 1.
>>>> I knew it was reported by the CC macro, but I don't understand why it
>>>> is happening. It is exactly the same code as is used for
>>>> MNOTE_CANON_TAG_SETTINGS_1 (which also has multiple components), but
>>>> no error there! Probably I forgot to add some code somewhere else,
>>>> but I don't see it.
>>> Just a wild guess:
>>> Did you adjust mnote_canon_entry_count_values() too?
>> I added an extra 'case MNOTE_CANON_TAG_FOCAL_LENGTH:' between the
>> others.
> 
> I inspected
> http://www.sno.phy.queensu.ca/~phil/exiftool/TagNames/Canon.html#FocalLength
> and here is what I have found out:
> 1) MNOTE_CANON_TAG_FOCAL_LENGTH data is expected to be of the
> EXIF_FORMAT_SHORT format and to have 4 items
> 2) the 1st value is FocalType, and not size of any kind.
> 
> I inspected
> http://www.sno.phy.queensu.ca/~phil/exiftool/TagNames/Canon.html#FocalLength
> and here is what I have found out:
> 1) MNOTE_CANON_TAG_FOCAL_LENGTH data is expected to be of the
> EXIF_FORMAT_SHORT format and to have 4 items
> 2) the 1st value is FocalType, and not size of any kind.
> 
> Thus the correct sanity checks & code are:
>    CF (entry->format, EXIF_FORMAT_SHORT, val, maxlen);
>    CC (entry->components, 4, val, maxlen);
>    if (t >= 4) return NULL;
>    vs = exif_get_short (entry->data + t * 2, entry->order);

I assumed that tags always have a variable size and therefore always 
have a length field. Because entry->components has the correct 
information (without specifying this value myself), I assumed that it 
came from this first value.

In the exiftool documentation, all the offsets start at one (with the 
exception of this FocalLength tag), while in libexif numbering starts at 
zero. I assumed this FocalLength offset was a mistake in the 
documentation. I'll need to investigate this further.

Re: [Libexif-devel] Need some help with adding support for extra canon makernotes

[Jan P. <pa...@pi...>]

Jef,

I inspected
http://www.sno.phy.queensu.ca/~phil/exiftool/TagNames/Canon.html#FocalLength
and here is what I have found out:
1) MNOTE_CANON_TAG_FOCAL_LENGTH data is expected to be of the
EXIF_FORMAT_SHORT format and to have 4 items
2) the 1st value is FocalType, and not size of any kind.

Thus the correct sanity checks & code are:
   CF (entry->format, EXIF_FORMAT_SHORT, val, maxlen);
   CC (entry->components, 4, val, maxlen);
   if (t >= 4) return NULL;
   vs = exif_get_short (entry->data + t * 2, entry->order);

Kind regards,
           Jan Patera

> Marcus Meissner wrote:
>> On Wed, Sep 06, 2006 at 03:39:30PM +0200, Jef Driesen wrote:
>>> Jan Patera wrote:
>>>>> case MNOTE_CANON_TAG_FOCAL_LENGTH:
>>>>>     CF (entry->format, EXIF_FORMAT_SHORT, val, maxlen);
>>>>>     n = exif_get_short (data, entry->order) / 2;
>>>>>     if (t >= n) return NULL;
>>>>>     CC (entry->components, n, val, maxlen);
>>>>>     vs = exif_get_short (entry->data + 2 + t * 2, entry->order);
>>>>> snprintf (buf, sizeof (buf), "0x%04x", vs);
>>>>>     strncpy (val, buf, maxlen - strlen (val));
>>>>>     break;
>>>>>
>>>>> But when I run the exif commandline utility, an error is reported
>>>>> for the new tag:
>>>>>
>>>>> Focal type          |Invalid number of components (4, expected 1).
>>>>>
>>>>> What am I doing wrong here?
>>>>
>>>> this message is printed by the CC macro. It checks whether
>>>> 1st & 2nd arguments are equal. apparently entry->components is 4,
>>>> but n is only 1.
>>> I knew it was reported by the CC macro, but I don't understand why it
>>> is happening. It is exactly the same code as is used for
>>> MNOTE_CANON_TAG_SETTINGS_1 (which also has multiple components), but
>>> no error there! Probably I forgot to add some code somewhere else,
>>> but I don't see it.
>>
>> Just a wild guess:
>> Did you adjust mnote_canon_entry_count_values() too?
>
> I added an extra 'case MNOTE_CANON_TAG_FOCAL_LENGTH:' between the
> others.

Re: [Libexif-devel] Need some help with adding support for extra canon makernotes

[Jef D. <jef...@ho...>]

Marcus Meissner wrote:
> On Wed, Sep 06, 2006 at 03:39:30PM +0200, Jef Driesen wrote:
>> Jan Patera wrote:
>>>> case MNOTE_CANON_TAG_FOCAL_LENGTH:
>>>>     CF (entry->format, EXIF_FORMAT_SHORT, val, maxlen);
>>>>     n = exif_get_short (data, entry->order) / 2;
>>>>     if (t >= n) return NULL;
>>>>     CC (entry->components, n, val, maxlen);
>>>>     vs = exif_get_short (entry->data + 2 + t * 2, entry->order);
>>>>     snprintf (buf, sizeof (buf), "0x%04x", vs);
>>>>     strncpy (val, buf, maxlen - strlen (val));
>>>>     break;
>>>>
>>>> But when I run the exif commandline utility, an error is reported for
>>>> the new tag:
>>>>
>>>> Focal type          |Invalid number of components (4, expected 1).
>>>>
>>>> What am I doing wrong here?
>>>
>>> this message is printed by the CC macro. It checks whether
>>> 1st & 2nd arguments are equal. apparently entry->components is 4,
>>> but n is only 1.
>> I knew it was reported by the CC macro, but I don't understand why it is
>> happening. It is exactly the same code as is used for
>> MNOTE_CANON_TAG_SETTINGS_1 (which also has multiple components), but no
>> error there! Probably I forgot to add some code somewhere else, but I
>> don't see it.
> 
> Just a wild guess:
> Did you adjust mnote_canon_entry_count_values() too?

I added an extra 'case MNOTE_CANON_TAG_FOCAL_LENGTH:' between the others.

Re: [Libexif-devel] Need some help with adding support for extra canon makernotes

[Jan P. <pa...@pi...>]

Apparently the data associated to tag MNOTE_CANON_TAG_FOCAL_LENGTH have
four short int values (because entry->components is 4).
The first value is 2 (you get 1 after dividing by 2). Is this what
you expect? Are you familiar with the format of the data
of this tag (I am not)?

 -- Jan

 Apparent
> Jan Patera wrote:
>>> case MNOTE_CANON_TAG_FOCAL_LENGTH:
>>>     CF (entry->format, EXIF_FORMAT_SHORT, val, maxlen);
>>>     n = exif_get_short (data, entry->order) / 2;
>>>     if (t >= n) return NULL;
>>>     CC (entry->components, n, val, maxlen);
>>>     vs = exif_get_short (entry->data + 2 + t * 2, entry->order);
>>> snprintf (buf, sizeof (buf), "0x%04x", vs);
>>>     strncpy (val, buf, maxlen - strlen (val));
>>>     break;
>>>
>>> But when I run the exif commandline utility, an error is reported for
>>> the new tag:
>>>
>>> Focal type          |Invalid number of components (4, expected 1).
>>>
>>> What am I doing wrong here?
>>
>>
>> this message is printed by the CC macro. It checks whether
>> 1st & 2nd arguments are equal. apparently entry->components is 4, but
>> n is only 1.
>
> I knew it was reported by the CC macro, but I don't understand why it is
> happening. It is exactly the same code as is used for
> MNOTE_CANON_TAG_SETTINGS_1 (which also has multiple components), but no
> error there! Probably I forgot to add some code somewhere else, but I
> don't see it.

Re: [Libexif-devel] Need some help with adding support for extra canon makernotes

[Marcus M. <mei...@su...>]

On Wed, Sep 06, 2006 at 03:39:30PM +0200, Jef Driesen wrote:
> Jan Patera wrote:
> >> case MNOTE_CANON_TAG_FOCAL_LENGTH:
> >>     CF (entry->format, EXIF_FORMAT_SHORT, val, maxlen);
> >>     n = exif_get_short (data, entry->order) / 2;
> >>     if (t >= n) return NULL;
> >>     CC (entry->components, n, val, maxlen);
> >>     vs = exif_get_short (entry->data + 2 + t * 2, entry->order);
> >>     snprintf (buf, sizeof (buf), "0x%04x", vs);
> >>     strncpy (val, buf, maxlen - strlen (val));
> >>     break;
> >>
> >> But when I run the exif commandline utility, an error is reported for
> >> the new tag:
> >>
> >> Focal type          |Invalid number of components (4, expected 1).
> >>
> >> What am I doing wrong here?
> > 
> > 
> > this message is printed by the CC macro. It checks whether
> > 1st & 2nd arguments are equal. apparently entry->components is 4,
> > but n is only 1.
> 
> I knew it was reported by the CC macro, but I don't understand why it is
> happening. It is exactly the same code as is used for
> MNOTE_CANON_TAG_SETTINGS_1 (which also has multiple components), but no
> error there! Probably I forgot to add some code somewhere else, but I
> don't see it.

Just a wild guess:
Did you adjust mnote_canon_entry_count_values() too?

Ciao, Marcus

Re: [Libexif-devel] Need some help with adding support for extra canon makernotes

[Jef D. <jef...@ho...>]

Jan Patera wrote:
>> case MNOTE_CANON_TAG_FOCAL_LENGTH:
>>     CF (entry->format, EXIF_FORMAT_SHORT, val, maxlen);
>>     n = exif_get_short (data, entry->order) / 2;
>>     if (t >= n) return NULL;
>>     CC (entry->components, n, val, maxlen);
>>     vs = exif_get_short (entry->data + 2 + t * 2, entry->order);
>>     snprintf (buf, sizeof (buf), "0x%04x", vs);
>>     strncpy (val, buf, maxlen - strlen (val));
>>     break;
>>
>> But when I run the exif commandline utility, an error is reported for
>> the new tag:
>>
>> Focal type          |Invalid number of components (4, expected 1).
>>
>> What am I doing wrong here?
> 
> 
> this message is printed by the CC macro. It checks whether
> 1st & 2nd arguments are equal. apparently entry->components is 4,
> but n is only 1.

I knew it was reported by the CC macro, but I don't understand why it is
happening. It is exactly the same code as is used for
MNOTE_CANON_TAG_SETTINGS_1 (which also has multiple components), but no
error there! Probably I forgot to add some code somewhere else, but I
don't see it.

Re: [Libexif-devel] Need some help with adding support for extra canon makernotes

[Jan P. <pa...@pi...>]

Jef,

this message is printed by the CC macro. It checks whether
1st & 2nd arguments are equal. apparently entry->components is 4,
but n is only 1.

Hope this helps..

    -- Jan

> case MNOTE_CANON_TAG_FOCAL_LENGTH:
>     CF (entry->format, EXIF_FORMAT_SHORT, val, maxlen);
>     n = exif_get_short (data, entry->order) / 2;
>     if (t >= n) return NULL;
>     CC (entry->components, n, val, maxlen);
>     vs = exif_get_short (entry->data + 2 + t * 2, entry->order);
>     snprintf (buf, sizeof (buf), "0x%04x", vs);
>     strncpy (val, buf, maxlen - strlen (val));
>     break;
>
> But when I run the exif commandline utility, an error is reported for
> the new tag:
>
> Focal type          |Invalid number of components (4, expected 1).
>
> What am I doing wrong here?
>
> [1] http://www.sno.phy.queensu.ca/~phil/exiftool/TagNames/Canon.html

[Libexif-devel] Need some help with adding support for extra canon makernotes

[Jef D. <jef...@ho...>]

Many makernote tags are already documented by the 'exiftool' project 
[1], but are not in the libexif library. I'm working on adding those 
canon makernotes to the libexif library. I already figured out how to 
add entries for already existing tags, but I'm having trouble adding new 
tags.

In mnote-canon-tag.h, I define the new tag:

MNOTE_CANON_TAG_FOCAL_LENGTH = 0x2

And in mnote-canon-tag.c, I add the necessary human readable names to 
both tables. And in mnote-canon-entry.c, I add a section to the function 
mnote_canon_entry_get_value. I copied more or less the code from section 
MNOTE_CANON_TAG_SETTINGS_1 as a starting point:

case MNOTE_CANON_TAG_FOCAL_LENGTH:
    CF (entry->format, EXIF_FORMAT_SHORT, val, maxlen);
    n = exif_get_short (data, entry->order) / 2;
    if (t >= n) return NULL;
    CC (entry->components, n, val, maxlen);
    vs = exif_get_short (entry->data + 2 + t * 2, entry->order);
    snprintf (buf, sizeof (buf), "0x%04x", vs);
    strncpy (val, buf, maxlen - strlen (val));
    break;

But when I run the exif commandline utility, an error is reported for 
the new tag:

Focal type          |Invalid number of components (4, expected 1).

What am I doing wrong here?

[1] http://www.sno.phy.queensu.ca/~phil/exiftool/TagNames/Canon.html

[Libexif-devel] =?iso-2022-jp?b?GyRCSlY7dkJUJEMkRiReJDkbKEIoQF9A?= =?iso-2022-jp?b?KQ==?=

[<ie_...@ya...>]

お住まいの近くの女性が入会いたしましたので、貴方からの返事を待っているそ
うです、貴方とのアド交換を希望していますが貴方のアドレスを女性に通知して
もよいですか?手続きは登録のみでokです【無料】。

【登録無料】

 http://rxtk.com?star2








送信停止:

拒否：ir...@qr...

Re: [Libexif-devel] haR Xri

[Viljo V. <opp...@ha...>]

Hi
=20
All yo j ur PHA h RRMAC g Y di c rec c tly from the ma m nufac e tu m
rer,
Your ch y anc p e to ec l ono i mize wi t th us
http://OakTreeInternet.info

  l=20

  d=20

  h=20

actuated by your body heat. It is always there, always turned on. You
Your criticism is becoming tiring.
Professor Van Diver I presume?

Re: [Libexif-devel] liRXtu

[Marjukka C. <cor...@jd...>]

This was sounding familiar. There has never been a strongman,

=20
Hi
, p=20
VI u AG f RA=20
V h ALI u UM=20
C o IAL j IS and m e an m y o w th c er
D g irectl v y from the m u anu w fact e urer
, k=20
S c AV v E up l to 50 u % w x ith http://abuhadefunkadesa.com

  h=20

  u=20

  n=20

Assembler. I think that it is the central computer here. In any case,
out. Or the one that brought me to much later. The women were gone and
was the last one to arrive, womans prerogative. Though I had better