Menu

#1 Patch: Catch the line number where assertCss was called.

current
closed
None
2018-04-08
2018-03-31
Mark Hung
No

Calling CPPUNIT_ASSERT inside assertCss hides the real line number
where assertCss is called. This patch replace CPPUNIT_ASSERT inside
assesrtCss with std::runtime_error(), rename assertCss to checkCss,
and replace assertCss(...) to CPPUNIT_ASSERT_NO_THROW(checkCss(...))
so developers can catch the failed line number easily.

1 Attachments

Discussion

  • Mark Hung

    Mark Hung - 2018-04-03

    Update patch to define CPPUNIT_ASSERT_CSS macro instead of throw exception.

     
  • David Tardon

    David Tardon - 2018-04-08
    • status: open --> closed
    • assigned_to: Miklos Vajna
    • Milestone: untriaged --> current
     
  • David Tardon

    David Tardon - 2018-04-08

    The final patch is different, but the problem is fixed.

     

Log in to post a comment.

MongoDB Logo MongoDB