Menu

#41 libdv-0.104: undefined C code and uninitialized variable

open-fixed
nobody
None
5
2006-09-21
2006-09-20
anosek
No

Wrote by David Binderman:
I just tried to compile package libdv-0.104-4 with a
prerelease of the
GNU C compiler version 4.1. It said

1.

encode.c:1811: warning: operation on "i" may be undefined

The source code is

for (i = 0;
i < (DV_WIDTH * (dv_enc->isPAL
? DV_PAL_HEIGHT :
DV_NTSC_HEIGHT));
dv_enc->img_y[i] =
CLAMP(dv_enc->img_y[i++], -224, 214)
);

I agree with the compiler - this code seems to be
undefined.

There is also use of uninitialized variable "w".

Discussion

  • anosek

    anosek - 2006-09-20

    patch for it

     
  • Dan Dennedy

    Dan Dennedy - 2006-09-21
    • status: open --> open-fixed
     
  • Dan Dennedy

    Dan Dennedy - 2006-09-21

    Logged In: YES
    user_id=78682

    These have all been addressed in CVS. I will close this
    with the next release.

     
MongoDB Logo MongoDB