Re: [libdv-dev] Problems with libdv

[Charles 'B. K. <kr...@ac...>]

Arne Schirmacher <ar...@sc...> writes:

> Please see this file to reproduce the problem:

> http://www.schirmacher.de/tmp/bug4.dv

> The bug shows only when using the gtk display, not when using Xv. So I 
> guess it must be somewhere in the RGB conversion.

Yes, it was reproduced on my side.  I seemed to have fixed it, by
expanding the range of the YUV clamp table.  

> This file shows more color conversion problems: Check the orange balloon. 
> This is also visible only in the gtk display version of playdv.

> http://www.schirmacher.de/tmp/bug1.dv

Yes, I see it, but I don't have a fix yet.  

> I noticed a strange effect when running playdv and using the Xv display 
> method: It incorrectly calculates the fps value printed to stdout. It 
> prints only "nan". I have a similar effect in Kino, where I calculated a 
> fps value too. Maybe this has something to do with fpu registers used by 
> mmx code?

Got it, I think.  There was a emms() call missing in the YV12 conversion code.

> The header files now correctly compile under C++, however the result won't 
> link because the 'extern "C" { ' directive is missing. (Sorry, I forgot to 
> mention this in the last email).

Ok, I've added these to the exported header files.

All of these changes are in CVS now.

-- Buck