Re: [libdc1394-devel] Non ISO C in dc1394/control.h

[Damien D. <ddo...@is...>]

On Mon, 2007-09-17 at 23:34 -0400, David Moore wrote:
> On Tue, 2007-09-18 at 12:00 +0900, Damien Douxchamps wrote:
> > So that means that we can't use things like:
> > 
> > DC1394_ERR_RTN(err, "failed. n=%d\n", n);
> > 
> > but we can only use
> > 
> > DC1394_ERR_RTN(err, "failed\n");
> > 
> > If possible, I would like to keep the macros as they are. Is ISO C
> > compliance important?
> > 
> 
> I think it's possible to achieve both.  See:
> 
> http://gcc.gnu.org/onlinedocs/cpp/Variadic-Macros.html

Indeed, but it only works in C99, not the default C90 (obvious, since
variadic macros were introduced in C99) I did the necessary changes in
the SVN433, including updating // comments to /* */ comments.

An interesting find when using the pedantic option is that some constant
overflows are detected in bayer.c. I left those because I don't know how
to handle that situation.

Note, at last, that the example program "dc1394_vloopback" does not
compile with the pedantic option, the file
"/usr/include/linux/videodev2.h" containing a few errors. So if a linux
include file is not C99 compliant maybe we don't have to be too...
pedantic ;)

Damien

-- 
  _    Damien 高原 Douxchamps
 ('-   Assistant Professor
 //\   Image Processing Laboratory, NAIST
 V_/_  http://damien.douxchamps.net/