Re: [libdc] libdc1394-2 patches

[Damien D. <dd...@do...>]

Hi Mike,

On Thu, 2009-02-05 at 18:52 -0800, Mike Lundy wrote:
> Here are some patches for libdc1394-2, against current trunk. Thanks,
> Damien, for cluing me in on how to send mail to the list :)
> 
> They're numbered in the order they're guaranteed to apply, but they
> don't really depend on each other.
> 
> The first makes it possible to build just the library, without the
> binaries.
> 
> The second fixes a gcc warning about missing initializers (the {0}
> doesn't seem to work for sub-parts of a struct initializer)
> 
> The third makes the user CFLAGS be appended instead of prepended (to
> allow overriding built-in cflags)
> 
> The fourth and fifth zero out buffers that could possibly be
> uninitialized (according to valgrind). Though, the solution here might
> be to move the zeroing-out into raw1394, since it's probably a good idea
> in general.
> 
> The last patch causes the conversions to return the error code from
> their delegates.
> 
> Feel free to apply any/all, or to poke me back if you don't like
> something about them. I'm not subscribed to the list, so keep me cc'd if
> you want me to change something about them :)

It did take me some time to do this but I have finally applied your
patches (SVN 588 - 591). I didn't apply 4 and 5 (valgrind inits) after
Stephan's reply but I'm open to discussion ;)

Cheers,

Damien


-- 
Damien 高原 Douxchamps    http://damien.douxchamps.net/