Re: [Libcg-devel] [PATCH 1/2] Improve error reporting in cgrulesengd.

[Ivana H. V. <var...@re...>]

On 11/08/2010 01:53 PM, Jan Safranek wrote:
> Before: Error: libcgroup initialization failed, 50001
> Now:    Error: libcgroup initialization failed, Cgroup is not mounted
>
> Signed-off-by: Jan Safranek<jsa...@re...>
> ---
>
>   src/daemon/cgrulesengd.c |   10 +++++-----
>   1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/src/daemon/cgrulesengd.c b/src/daemon/cgrulesengd.c
> index b96107d..ffcfc85 100644
> --- a/src/daemon/cgrulesengd.c
> +++ b/src/daemon/cgrulesengd.c
> @@ -1013,23 +1013,23 @@ int main(int argc, char *argv[])
>
>   	/* Initialize libcgroup. */
>   	if ((ret = cgroup_init()) != 0) {
> -		fprintf(stderr, "Error: libcgroup initialization failed, %d\n",
> -				ret);
> +		fprintf(stderr, "Error: libcgroup initialization failed, %s\n",
> +				cgroup_strerror(ret));
>   		goto finished;
>   	}
>
>   	/* Ask libcgroup to load the configuration rules. */
>   	if ((ret = cgroup_init_rules_cache()) != 0) {
>   		fprintf(stderr, "Error: libcgroup failed to initialize rules"
> -				"cache, %d\n", ret);
> +				"cache, %s\n", cgroup_strerror(ret));
there should be a space between rules and cache, it would be fine to 
have here the rule cache file name
the result is now puzzled:
Error: libcgroup failed to initialize rulescache, No such file or directory

>   		goto finished;
>   	}
>
>   	/* Now, start the daemon. */
>   	ret = cgre_start_daemon(logp, facility, daemon, verbosity);
>   	if (ret<  0) {
> -		fprintf(stderr, "Error: Failed to launch the daemon, %d\n",
> -			ret);
> +		fprintf(stderr, "Error: Failed to launch the daemon, %s\n",
> +			cgroup_strerror(ret));
>   		goto finished;
>   	}
>
>
>
> ------------------------------------------------------------------------------
> The Next 800 Companies to Lead America's Growth: New Video Whitepaper
> David G. Thomson, author of the best-selling book "Blueprint to a
> Billion" shares his insights and actions to help propel your
> business during the next growth cycle. Listen Now!
> http://p.sf.net/sfu/SAP-dev2dev
> _______________________________________________
> Libcg-devel mailing list
> Lib...@li...
> https://lists.sourceforge.net/lists/listinfo/libcg-devel