Re: [Lib2geom-devel] SBasis questions

[<J.B...@ew...>]

> -----Original Message-----
> From: Nathan Hurst [mailto:nj...@nj...]
> Sent: 05 February 2011 09:51
> To: A.J...@br...
> Cc: Engelen, J.B.C. (Johan); lib...@li...
> Subject: Re: [Lib2geom-devel] SBasis questions
> 
> On Sat, Feb 05, 2011 at 07:59:17AM +0000, A.J...@br...
> wrote:
> > Dear all,
> > On Fri, 2011-02-04 at 22:42 +0100, J.B...@ew...
> wrote:
> > > Chiming in quickly about this orphan directory idea. I think it is
> a
> > > very good idea! :-) Move all files that are no longer directly
used
> into
> > > such a directory. This makes 2geom more accessible for new users.
> > Rather than an orphan directory, and requiring calling code to be
> > modified, would it make more sense to simply guard the code with an
> > ifdef.  For example
> >
> > #ifdef USE_ORPHAN_CODE
> > ...
> > #endif
> >
> > Then it's not necessary to modify calling code but only to add a
> > -DUSE_ORPHAN_CODE to a build.
> >
> > This seems neater to me than (a) changing any existing calling code,
> and
> > (b) re-changing future calling code when the functions become
> > unorphaned?
> 
> That's a good suggestion, but the main reason for the orphan directory
> was to reduce the amount of dead code in the library proper.  Moving
> files isn't hard, and makes it clear what's important and what's not.

I am going to move some of the files that are excluded from the build
(by CmakeLists.txt) to the new directory "orphan code".
If anybody wants to start using the code again, it should be moved from
orphan code to the normal 2geom dir. Since there is no code calling it,
no need to change it. If there is code *outside* 2geom that is using the
'orphan' files, I hope those programmers won't be too mad at me for
moving the files to a different place. At least it will show them that
that code is probably no longer maintained, and it could break any
moment (since it is not included in 2geom building).

Ciao,
  Johan