Menu

#15 Don't realise widget before it is created

closed-fixed
nobody
Xm library (13)
5
2004-05-27
2004-05-26
Herbert Xu
No

My LTRemoveGrab patch that you applied previously broke
nedit again. I've found the real culprit. The problem
is that the grabs are being added by the init functions
rather than popup. That in turn is caused by DialogS
realising the widget before it has been created properly.

The following patch fixes the problem.

Discussion

  • Herbert Xu

    Herbert Xu - 2004-05-26

    Don't realise widget before it is created

     
  • Danny Backx

    Danny Backx - 2004-05-26

    Logged In: YES
    user_id=39146

    Applied your patch.

     
  • Danny Backx

    Danny Backx - 2004-05-26
    • status: open --> closed-fixed
     
  • Danny Backx

    Danny Backx - 2004-05-26
    • status: closed-fixed --> open-invalid
     
  • Danny Backx

    Danny Backx - 2004-05-26

    Logged In: YES
    user_id=39146

    Err. I'm pulling this one back as it breaks the report
    dialog in Xinvest.

     
  • Herbert Xu

    Herbert Xu - 2004-05-26

    Logged In: YES
    user_id=453578

    Since I'm not faimilar with xinvest, can you give me a
    simple list of actions you performed to trigger the problem?

    Thanks,

     
  • Herbert Xu

    Herbert Xu - 2004-05-27

    Fix xinvest report regression

     
  • Herbert Xu

    Herbert Xu - 2004-05-27

    Logged In: YES
    user_id=453578

    OK, I went into the CVS and dug up the change that
    introduced this bogus XtRealizeWidget call. Well that
    provides the answer to both your problem as well as to why
    the original change was needed.

    Firstly your problem is caused by the lack of an
    XtRealiseWidget call before the child is inserted in
    DialogS's insert_child.

    The original problem was caused by a simple ordering issue
    between the parent insert_child call and XtRealizeWidget.
    So it appears to have been misdiagonised previously and
    hence incorrectly fixed.

    The patch p1 should fix all of these problems.

     
  • Danny Backx

    Danny Backx - 2004-05-27
    • status: open-invalid --> closed-fixed
     

Log in to post a comment.