Menu

#36 lensfun 0.3.2 broken on Ubuntu 12.04

fixed
seebk
None
2015-11-25
2015-11-20
letmaik
No

lensfun 0.3.2 raised the minimum glib version to 2.40 (which in my opinion would at least require a minor version change) but the latest glib version on Ubuntu 12.04 is 2.32. So basically you removed Ubuntu 12.04 support in a patch release :)

By the way, the error message I got was quite misleading:

In file included from /usr/include/glib-2.0/glib/gtypes.h:36:0,
                 from /usr/include/glib-2.0/glib/galloca.h:34,
                 from /usr/include/glib-2.0/glib.h:32,
                 from /home/travis/build/neothemachine/lensfun/libs/lenfun/lensfunprv.h:9,
                 from /home/travis/build/neothemachine/lensfun/libs/lensfun/camera.cpp:8:

/usr/include/glib-2.0/glib/gversionmacros.h:145:2: error: #error "GLIB_VERSION_MIN_REQUIRED must be >= GLIB_VERSION_2_26"

make[2]: *** [libs/lensfun/CMakeFiles/lensfun.dir/camera.cpp.o] Error 1
make[1]: *** [libs/lensfun/CMakeFiles/lensfun.dir/all] Error 2

I noticed it on a Travis CI build of my lensfunpy wrapper:
https://travis-ci.org/neothemachine/lensfunpy/jobs/92335513#L148

I guess there are two ways out: Either support glib 2.32, or officially say that Ubuntu 12.04 is not supported anymore.

Discussion

  • seebk

    seebk - 2015-11-21

    I think it is ok that we drop backwards compatibility with a distribution released 3.5 years ago. However, you are right that the error message is misleading. Unfortunately I could not find out if this could be improved. AFIK we set the version macros exactly as described in the glib docs.

    If you do not need the automatic tests you can try the latest commit from our repository where I have lowered the minimum required glib version in case the tests are disabled. Run cmake with the -DBUILD_TESTS=no option and it should still work well with old glib versions.

     

    Last edit: seebk 2015-11-21
    • letmaik

      letmaik - 2015-11-24

      Great, just tried it with the latest commit and it works.
      https://travis-ci.org/neothemachine/lensfunpy/jobs/92914841

       
  • seebk

    seebk - 2015-11-25

    Good, thanks for the feedback!

     
  • seebk

    seebk - 2015-11-25
    • status: open --> fixed
    • assigned_to: seebk