Menu

#1304 Check printing does not support invoices, legal_name

1.4
closed-fixed
nobody
None
1.2
5
2015-10-18
2014-12-17
John Locke
No

The default check_base.tex template illustrates using and which are not expanding.

Also, the block that prints invoice summaries doesn't print anything:

<?lsmb FOR inv = invoices ?>
<?lsmb inv.invnumber ?> & <?lsmb inv.invoice_date ?> \dotfill
  & <?lsmb inv.due ?> & <?lsmb inv.paid ?> \\
<?lsmb END # FOREACH inv ?>

... so when printing checks using cash -> vouchers -> payments, date, amount, and address are coming through sucessfully, but payee/company name, and invoice payment amounts are not.

This is on a set of books that has been upgraded from 1.3.

Discussion

  • John Locke

    John Locke - 2014-12-17
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -2,10 +2,12 @@
    
     Also, the block that prints invoice summaries doesn't print anything: 
    
    +~~~~~
     <?lsmb FOR inv = invoices ?>
     <?lsmb inv.invnumber ?> & <?lsmb inv.invoice_date ?> \dotfill
       & <?lsmb inv.due ?> & <?lsmb inv.paid ?> \\
     <?lsmb END # FOREACH inv ?>
    +~~~~~
    
     ... so when printing checks using cash -> vouchers -> payments, date, amount, and address are coming through sucessfully, but payee/company name, and invoice payment amounts are not.
    
     
  • Chris Travers

    Chris Travers - 2014-12-18

    I don;t think the check printing from ar/ap transactions doesn;t make a lot of sense. Given that it doesn't seem to be used at present, I am going to suggest we remove this feature.

     
  • Chris Travers

    Chris Travers - 2014-12-18

    Payto/payee stuff should be fixed though. I will get to this quickly.

     
  • John Locke

    John Locke - 2014-12-19

    Ok. Payee/Pay-to in the templates seems to use legal_name or company. In LedgerSMB/Scripts/payment.pm, in the sub print I found that the check detail comes from the company_get_billing_info stored function.

    When I call this, the return I get for the payee name is "name".

    So to get the name to print, I added
    name = check.name

    ... in the check_multiple template (in the database), inside the for loop include,

    ... and then changed "company" and "legal_name" inside templates/demo/check_base.tex to "name" and now the name prints.

    For the invoice summaries, I just needed to go to the System -> Defaults and set a value for "Max Invoices per Check Stub" to something non-blank.

    So I think all that's necessary here is to update the default templates, and add these as notes to upgrade documentation. And fix the check template management (Issue #1302)/TeX inclusion issue (#1297)...

     
  • Anonymous

    Anonymous - 2015-01-15
    • status: open --> pending-fixed
     
  • Anonymous

    Anonymous - 2015-01-15

    Hi all, I'm assuming this is a 1.4-only bug? (Even though marked as 1.3...)

     
  • John Locke

    John Locke - 2015-01-15

    Yes, this is 1.4, not 1.3...

     
  • John Locke

    John Locke - 2015-01-15
    • Group: 1.3 --> 1.4
     
  • Chris Travers

    Chris Travers - 2015-10-18

    At this point, we are looking at th tex inclusion issue and the tex template editing issue. Going to close this for now. If there are other bugs found in this corner we can re-open or file new reports

     
  • Chris Travers

    Chris Travers - 2015-10-18
    • status: pending-fixed --> closed-fixed
    • Version: --> 1.2
     
MongoDB Logo MongoDB