Re: [ldap-sdk-discuss] Source code

[Alon Bar-L. <alo...@gm...>]

On Sun, May 25, 2014 at 2:07 AM, Neil A. Wilson
<nei...@un...> wrote:
> On 05/09/2014 04:23 PM, Neil A. Wilson wrote:
>>
>> On 05/09/2014 03:30 PM, Alon Bar-Lev wrote:
>>>
>>> Thank you. Please make the checkstyle target optional, you can do this
>>> via condition using property on its target.
>
>
> I have just committed a change that allows checkstyle processing to be
> skipped if the "checkstyle.enabled" property is set with a value of "false"
> (e.g., "./build-se.sh -Dcheckstyle.enabled=false").
>
> I'm still not entirely sure why this is necessary, or even useful.  The only
> time it would possibly be of any benefit would be if you're maintaining your
> own fork of the LDAP SDK, in which case you could just update your own copy
> to not do checkstyle processing (or, alternately, you could just write code
> that meets the checkstyle requirements).  At any rate, the change wasn't
> difficult so it's there now.
>

Thank you!
I was kind of hopping you remove the all of the binaries from the repo
and have this false by default.

The implementation of conditional could have been simpler. Ant
supports condition per target, and overriding attributes.

Attached two patches as an example:
1. simpling and conditionals at checkstyles check.
2. enable checkstyle by default if binaries available, this will
enable you to keep the same behaviour at your internal build system.

I will try to explain again why binaries should not be published.

If I am (or any other open source) to use this package, I need to
package it for various distributions, rhel, centos, fedora, gentoo,
...

As open source is all about the sources, package is required to be
built from sources, without any implicit or explicit binary reference.

This is why one never sees binaries checked into source repositories,
they are useless. The recent commit:

    Update the version of Apache Ant included in the LDAP SDK repository to
    version 1.9.4.

Is something you do not see in source repositories, as 3rd parties
should be taken from 3rd party, and especially not see binaries.

Having ant on a computer that compiles an open source project is a
trivial requirement, no need to bloat repository with binaries, same
for check-style as a simple -Dcheckstyle.dir=xxx should be sufficient.
There cannot be a situation in which one runs a build of something
that is published as an open source and during the build a binary blob
is executed (checkstyle in this case).

I recommend you remove the ext directory from the open source
repository leaving only sources and make the build.xml pass without
any special settings.

But at least consider the attached patches, to allow removing the ext
directory post checkout to make sure that no binaries are used.

Thank you,
Alon Bar-Lev