|
From: Neil A. W. <nei...@un...> - 2014-05-24 23:07:47
|
On 05/09/2014 04:23 PM, Neil A. Wilson wrote: > On 05/09/2014 03:30 PM, Alon Bar-Lev wrote: >> Thank you. Please make the checkstyle target optional, you can do this >> via condition using property on its target. I have just committed a change that allows checkstyle processing to be skipped if the "checkstyle.enabled" property is set with a value of "false" (e.g., "./build-se.sh -Dcheckstyle.enabled=false"). I'm still not entirely sure why this is necessary, or even useful. The only time it would possibly be of any benefit would be if you're maintaining your own fork of the LDAP SDK, in which case you could just update your own copy to not do checkstyle processing (or, alternately, you could just write code that meets the checkstyle requirements). At any rate, the change wasn't difficult so it's there now. Neil |