Re: [Lcms-user] [Release candidate]

[Marti M. <mar...@li...>]

Hi Noel,

Thank you for the testing. Is there any of those warnings that you consider should be fixed upstream? I also tried -Wall as well as static analysis but found many of those warnings are just informative about actions taken by the compiler. Adding alignment to structures for example. Compiler parser also emits warning for things like using default: on switch(), which is completely legal (and necessary!) Regarding /Qsprectre, oh, well, this is entirely generated and handled by the compiler itself, as C code knows nothing on this vulnerability. 

Regards
Marti


> On 8 Jan 2021, at 06:40, Noel Carboni <NCa...@Pr...> wrote:
> 
> Hi Marti,
>  
> I have built your version 12 RC1 code (without the fast float plug-in) into my Photoshop plug-in products and it has tested well, proving quite capable of doing all the transforms that we need.  Thanks for your ongoing work to clean up the code and make the Little CMS implementation more robust - it's literally been years since anyone's reported a color-management problem against any of our products, with Little CMS doing the color work under the covers.
>  
> FWIW because we compile with the C++ compiler and use -wAll plus the Code Analyzer, I change a few lines of your code (mostly to add explicit casts), and also we suppress several specific warning classes (/wd4061 /wd4711 /wd4774 /wd4820 /wd5045) in our version of the project. 
>  
> Examples of the above-mentioned suppressed warnings:
>  
> warning C4061: enumerator 'SBEGIN_DATA' in switch of enum 'SYMBOL' is not explicitly handled by a case label
> warning C4711: function 'unsigned short __cdecl _cmsFloat2Half(float)' selected for automatic inline expansion
> warning C4774: '_snprintf' : format string expected in argument 3 is not a string literal 
> warning C4820: '_cms_NAMEDCOLORLIST_struct': '2' bytes padding added after data member '_cms_NAMEDCOLORLIST_struct::Suffix'
> warning C5045: Compiler will insert Spectre mitigation for memory load if /Qspectre switch specified
>  
> -Noel Carboni
> ProDigital Software