Re: [Lcms-user] Release candidate of lcms2-2.10 available
An ICC-based CMM for color management
Brought to you by:
mm2
From: Carles L. <car...@in...> - 2020-05-29 12:42:21
|
Hello all, we found with the latest releases that we can't save DeviceLink profiles to memory buffers or files. We create DeviceLink profiles "on the fly". The input is normally RGB and the output can be anything from 1CLR to FCLR The function Type_Lut16_Write returns with an error if the inputCha * outputCha is not 9, in the case that the LUT has no matrix. ... if (!_cmsWriteUInt8Number(io, (cmsUInt8Number) InputChannels)) return FALSE; if (!_cmsWriteUInt8Number(io, (cmsUInt8Number) OutputChannels)) return FALSE ; if (!_cmsWriteUInt8Number(io, (cmsUInt8Number) clutPoints)) return FALSE; if (!_cmsWriteUInt8Number(io, 0)) return FALSE; // Padding n = NewLUT->InputChannels * NewLUT->OutputChannels; if (MatMPE != NULL) { for (i = 0; i < n; i++) { if (!_cmsWrite15Fixed16Number(io, MatMPE->Double[i])) return FALSE; } } else { if (n != 9) return FALSE; if (!_cmsWrite15Fixed16Number(io, 1)) return FALSE; if (!_cmsWrite15Fixed16Number(io, 0)) return FALSE; if (!_cmsWrite15Fixed16Number(io, 0)) return FALSE; if (!_cmsWrite15Fixed16Number(io, 0)) return FALSE; if (!_cmsWrite15Fixed16Number(io, 1)) return FALSE; if (!_cmsWrite15Fixed16Number(io, 0)) return FALSE; if (!_cmsWrite15Fixed16Number(io, 0)) return FALSE; if (!_cmsWrite15Fixed16Number(io, 0)) return FALSE; if (!_cmsWrite15Fixed16Number(io, 1)) return FALSE; } ... We think that the verification about the number of elements of the matrix (n != 9) should be in the other case, not in the place where the identity matrix is written. Do you think you can fix it? Are we wrong? Thanks a lot Carles Llopis On Sat, May 23, 2020 at 5:38 PM <mar...@li...> wrote: > > Hello, > > Many thanks to everybody for testing & reporting. > > Here is release candidate 2, with all glitches you have found hopefully > fixed. > > http://www.littlecms.com/lcms2-2.10rc2.tar.gz > > Best regards > Marti Maria > The LittleCMS Project > http:\www.littlecms.com > > > > > _______________________________________________ > Lcms-user mailing list > Lcm...@li... > https://lists.sourceforge.net/lists/listinfo/lcms-user > -- La información contenida en este mensaje y/o archivo(s) adjunto(s), enviada desde INEDIT SOFTWARE SL, es confidencial/privilegiada y está destinada a ser leída sólo por la(s) persona(s) a la(s) que va dirigida. Si usted lee este mensaje y no es el destinatario señalado, el empleado o el agente responsable de entregar el mensaje al destinatario, o ha recibido esta comunicación por error, le informamos que está totalmente prohibida y puede ser ilegal cualquier divulgación, distribución o reproducción de esta comunicación, y le rogamos que nos lo notifique inmediatamente y nos devuelva el mensaje original a la dirección arriba mencionada. Gracias. POLÍTICA DE PRIVACIDAD <https://www.inedit.com/es/aviso-legal/> The information contained in this message and/or attached file(s), sent from INEDIT SOFTWARE SL, is confidential/privileged and is intended to be read only by the person(s) to whom it is adressed. If you read this message and you are not the designated recipient, employee or agent responsible for delivering the message to the recipient, or have received this communication by mistake, we inform you that it is totally prohibited and may be illega, any disclosure, distribution or reproduction of this communication, and we ask you to notify us immediately and return the original message to the address mentioned above. Thank you. PRIVACY & TERMS <https://www.inedit.com/en/aviso-legal/> |