Re: [Lcms-user] Revision 485 "Constify some big arrays to allow to compiler put them in read only section." breaks VS 2017 builds

[Noel C. <NCa...@Pr...>]

Looks like you've got the trunk code compiling again Marti.  Thank you.

I presume, given that the tables are linked lists, that those tables are
not designed to be expanded (i.e., by linking additional entries to
them).  That they are qualified as const now precludes that.

 

I'm sending these messages about development code to the lcms-user
list...  Is there an lcms-developer list I should rather be using
instead?

 

-Noel

 

From: Noel Carboni [mailto:NCa...@Pr...] 
Sent: Tue, August 22, 2017 12:09 PM
To: 'lcm...@li...'
Subject: Revision 485 "Constify some big arrays to allow to compiler put
them in read only section." breaks VS 2017 builds

 

Hi folks,

 

The current Little CMS trunk does not build at all with the VS 2017 C++
compiler.

 

    ..\..\..\src\cmspack.c(3018): error C2440: 'initializing': cannot
convert from 'const cmsFormatters16 *' to 'cmsFormatters16 *'

    ..\..\..\src\cmspack.c(3018): note: Conversion loses qualifiers

    ..\..\..\src\cmspack.c(3030): error C2440: 'initializing': cannot
convert from 'const cmsFormattersFloat *' to 'cmsFormattersFloat *'

    ..\..\..\src\cmspack.c(3030): note: Conversion loses qualifiers

    ..\..\..\src\cmspack.c(3175): error C2440: 'initializing': cannot
convert from 'const cmsFormatters16 *' to 'cmsFormatters16 *'

    ..\..\..\src\cmspack.c(3175): note: Conversion loses qualifiers

 

    ..\..\..\src\cmstypes.c(5329): error C2440: 'initializing': cannot
convert from 'const _cmsTagTypeLinkedList *' to
'_cmsTagTypeLinkedList_st *'

    ..\..\..\src\cmstypes.c(5329): note: Conversion loses qualifiers

    ..\..\..\src\cmstypes.c(5419): error C2664: 'cmsTagTypeHandler
*GetHandler(cmsTagTypeSignature,_cmsTagTypeLinkedList
*,_cmsTagTypeLinkedList *)': cannot convert argument 3 from 'const
_cmsTagTypeLinkedList [31]' to '_cmsTagTypeLinkedList *'

    ..\..\..\src\cmstypes.c(5419): note: Conversion loses qualifiers

    ..\..\..\src\cmstypes.c(5524): error C2440: 'initializing': cannot
convert from 'const _cmsTagLinkedList *' to '_cmsTagLinkedList_st *'

    ..\..\..\src\cmstypes.c(5524): note: Conversion loses qualifiers

    ..\..\..\src\cmstypes.c(5624): error C2440: '=': cannot convert from
'const _cmsTagLinkedList [64]' to '_cmsTagLinkedList *'

    ..\..\..\src\cmstypes.c(5624): note: Conversion loses qualifiers

 

The change is a good idea but the whole job has to be done, so that all
the types match everywhere.

 

-Noel