From: Bob F. <bfr...@si...> - 2017-08-03 17:30:04
|
On Wed, 2 Aug 2017, Aaron Boxer wrote: > Thanks to Noel and Marti for these improvements ! > > On OSX, my warning count has gone from 20 to 2. > > Here are the two remaining warnings: > > http://my.cdash.org/buildSummary.php?buildid=1262991 For 64-bit Windows builds, 'unsigned long' is only a 32-bit type but 'size_t' is a 64-bit type. It seems likely that there are many more problems when computing size_t values given apparent assumptions that 'unsigned long' will be large enough. Integer overflow may occur. There will also be more prominence of sign-extension problems, which can create security risks. Have test compiles also been done for 64-bit Windows builds? Bob -- Bob Friesenhahn bfr...@si..., http://www.simplesystems.org/users/bfriesen/ GraphicsMagick Maintainer, http://www.GraphicsMagick.org/ |