Re: [Lcms-user] Build warnings on OSX / clang

[Aaron B. <bo...@gm...>]

Hi Marti,

Thanks. I've turned on this warning in my build because the implicit
conversion can cause
hard-to-trace bugs.

Regards,
Aaron

On Mon, Jul 24, 2017 at 3:10 AM, Martí Maria <mar...@li...>
wrote:

>
> Thanks for reporting.
>
> lcms uses the C feature of implicit sign conversion, so if you activate
> -Wsign-conversion you will get some warnings.
>
> This not set in the included build system.
>
> Regards
>
> Marti
>
> On 7/24/2017 3:16 AM, Aaron Boxer wrote:
>
> Hello,
> Just wanted to report a few warnings I am getting when building with clang.
>
> http://my.cdash.org/viewBuildError.php?type=1&buildid=1257347
>
> For example:
>
> <a href='https://github.com/GrokImageCompression/grok/blob/master/grok/thirdparty/liblcms2/src/cmsgamma.c#L143'>grok/thirdparty/liblcms2/src/cmsgamma.c:143</a>:32: warning: implicit conversion changes signedness: 'cmsUInt32Number' (aka 'unsigned int') to 'int' [-Wsign-conversion]
>     fl ->nFunctions = Plugin ->nFunctions;
>                     ~ ~~~~~~~~~^~~~~~~~~~
> <a href='https://github.com/GrokImageCompression/grok/blob/master/grok/thirdparty/liblcms2/src/cmsgamma.c#L150'>grok/thirdparty/liblcms2/src/cmsgamma.c:150</a>:63: warning: implicit conversion changes signedness: 'int' to 'unsigned long' [-Wsign-conversion]
>     memmove(fl->FunctionTypes,  Plugin ->FunctionTypes,   fl->nFunctions * sizeof(cmsUInt32Number));
>
>
> Thanks,
>
> Aaron
>
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>
>
>
> _______________________________________________
> Lcms-user mailing lis...@li...https://lists.sourceforge.net/lists/listinfo/lcms-user
>
>
>
> ------------------------------------------------------------
> ------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Lcms-user mailing list
> Lcm...@li...
> https://lists.sourceforge.net/lists/listinfo/lcms-user
>
>