Re: [Lame-dev] Patch to quantize_pvt.[c,h] for MacOSX

[Don M. <do...@bl...>]

I've examined the patch.

Because LAME already complies on Mac OS X version 10.1.1 from the 
command line and because this change doesn't free the memory allocated 
for the arrays, I don't think we should take the patch.

My two cents. :/

BTW, which version of OS X and Project Builder are you using to compile 
LAME?  And have you tried to build your modules from the command line?

-- Gramps

On Monday, November 19, 2001, at 02:13 PM, SKoT McDonald wrote:

> Hello all,
>
> I would like to suggest the following patch to help
> LAME compile on OSX, as Project Builder seems
> less that happy with the global variable arrays declared
> in quantize_pvt.[c,h]. I replaced the arrays with float32*
> and allocated them in the iteration_init() (or similar)
> function. LAME then works + compiles great on OSX.
>
> Could this patch be incorporated into the source?
>
>  FYI, we are working on building MP3 streaming modules
> into the SndKit/MusicKit (see www.musickit.org) to use
> along side icecast.
>
>  Great work, LAME crew!
>
>  Please find attached a diff/patch file, which should only
> affect the quantize_pvt.[c,h] files if used from the
> directory above your lame distrib, otherwise the raw
> files themselves are inclued too.
>
>  TODO: Need place to free() the memory malloc'ed by
> my patch, d'oh.
>
>  - SKoT
>
>