From: Naoki S. <n-s...@ic...> - 2000-12-14 00:47:09
|
Hi Alexander, Sorry, I wanted to send this mail to lame-dev ML, but I accidentally sent this to you(Simply hitting reply button doesn't work like lame main ML). >Yes, the old one worked, but the new one is "more correct", or better: >it gives more hints about the code flow. >That's IMHO an improvement, and improvements are good by definition, >right? >He produces an infrastructure on >which he want's to improve various things. We can't do listening tests >on not written code, and maintaining a huge diff is very time consuming, >time which is better spend on improving lame. If you believe so, please make your branch and make cleaner, c++ compilable, lower memory consumption and 8086 friendly lame on that branch. I always thought that I storongly dislike Frank's code. I also think he's changing code because simply he doesn't like the original code, and after his change, I don't like his new code. Perhaps it's a matter of each person's sense of values. I can't explain why I don't like his code. I think the original code is not so bad, and his new code always looks VERY UGLY. Do you really think T_IF,T_ELIF,T_END macros introduced by Frank is good? Do you really think new bitrate histgram display introduced by Frank is good? I dislike both of them. Again, perhaps this is a matter of each person's sense of values, but it seems that at least Mark, I and Takehiro don't like Frank's sense of values. I strongly hope that Frank's code will never be introduced if there is no functional improvement. -- Naoki Shibata e-mail: shi...@ge... |