Re: [Lame-dev] lame 3.101 beta 1 in SVN...

[Thomas O. <tho...@or...>]

Am Tue, 09 Mar 2021 16:51:03 +0100
schrieb Fabian Greffrath via Lame-dev <lam...@li...>: 

> Confirmed. the configure script should probably check for the existence
> of this library and its headers instead of blindly assuming it's
> installed.
> 
> Simply installing the -dev package and continuing "make" doesn't work.
> It will fail with link errors against libmpg123 symbols.

The configure script correctly checks for mpg123≥1.26.0 …

checking for mpg123... no
checking use of mpg123 decoder... enabled use of external libmpg123 decoder

… but if fails to follow up on that. The relevant logic:

dnl mpg123 decoder
PKG_CHECK_MODULES([mpg123], [libmpg123 >= 1.26.0], [HAVE_MPG123="yes"], [HAVE_MPG123="no"])

AC_MSG_CHECKING(use of mpg123 decoder)
AC_ARG_ENABLE(decoder,
  [  --disable-decoder          Exclude mpg123 decoder],
  CONFIG_DECODER="${enableval}", CONFIG_DECODER="yes")
CONFIG_MPG123=${CONFIG_DECODER}

if test "${CONFIG_MPG123}" = "auto" && test "${HAVE_MPG123}" = "yes"; then
        CONFIG_MPG123="yes"
fi


The default value of CONFIG_MPG123 is determined by the default value
of CONFIG_DECODER, which is yes. It probably should be $HAVE_MPG123 instead.


Alrighty then,

Thomas