[Lame-dev] compiling lame 3.100 fails on macOS 10.13

[Robert H. <Rob...@gm...>]

There is a report on hydrogenaud.io, that compiling 3.100 fails on MacOS 10.13:

libtool: link: gcc -dynamiclib  -o .libs/libmp3lame.0.dylib  .libs/VbrTag.o .libs/bitstream.o .libs/encoder.o .libs/fft.o .libs/gain_analysis.o .libs/id3tag.o .libs/lame.o .libs/newmdct.o .libs/presets.o .libs/psymodel.o .libs/quantize.o .libs/quantize_pvt.o .libs/reservoir.o .libs/set_get.o .libs/tables.o .libs/takehiro.o .libs/util.o .libs/vbrquantize.o .libs/version.o .libs/mpglib_interface.o   -Wl,-force_load,../libmp3lame/vector/.libs/liblamevectorroutines.a -Wl,-force_load,../mpglib/.libs/libmpgdecoder.a  -lm    -install_name  /usr/local/lib/libmp3lame.0.dylib -compatibility_version 1 -current_version 1.0 -Wl,-single_module -Wl,-exported_symbols_list,.libs/libmp3lame-symbols.expsym
Undefined symbols for architecture x86_64:
   "_lame_init_old", referenced from:
      -exported_symbol[s_list] command line option
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[3]: *** [libmp3lame.la] Error 1
make[2]: *** [all-recursive] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2


The problem seems to be, that we now export the deprecated "lame_init_old"
function. It seems to be related to this commit, where this function was added
to the export list:

Revision: 6302
Author: rbrito
Date: Dienstag, 11. Juni 2013 08:46:04
Message:
libmp3lame: Regenerate libmp3lame.sym from header file.

Part of patch submitted by Reimar Döffinger on ticket #63.

We should review this to check if there are any symbols that we don't want
exported.

----
Modified : /trunk/lame/include/libmp3lame.sym


I guess, nobody had had the time to review the patch?


Ciao Robert