[Lame-dev] [ lame-Bugs-3441349 ] --tg does not handle genre number when adding unicode tag

[SourceForge.net <no...@so...>]

Bugs item #3441349, was opened at 2011-11-22 23:01
Message generated for change (Comment added) made by tmkk
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100290&aid=3441349&group_id=290

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Frontends (lame/mp3x/...)
Group: None
Status: Open
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Taihei Monma (tmkk)
Assigned to: Robert Hegemann (robert)
Summary: --tg does not handle genre number when adding unicode tag

Initial Comment:
This is because id3tag_set_textinfo_utf16 is called directly when adding unicode tags.

Solution will be:
a) handle in frontend
b) handle (silently) in id3tag_set_textinfo_utf16 for TCON frame
c) add id3tag_set_genre equivalent for unicode

For solution c), the attached patch will do.

----------------------------------------------------------------------

>Comment By: Taihei Monma (tmkk)
Date: 2011-11-26 13:21

Message:
Hm, but --tg along with the --id3v2-latin1 switch (and lame prior to 3.99)
always adds v2.3 tag.

----------------------------------------------------------------------

Comment By: Robert Hegemann (robert)
Date: 2011-11-26 12:37

Message:
That's not a bug, the --tg switch triggers an id3v2 tag only, if the user
adds some genre, which isn't one of the common genres.

----------------------------------------------------------------------

Comment By: Taihei Monma (tmkk)
Date: 2011-11-26 10:55

Message:
Now it works but v2.3 tag is not added when only --tg  is specified.

in id3tag_set_genre_utf16:

gfc->tag_spec.flags |= CHANGED_FLAG;
should be
gfc->tag_spec.flags |= (CHANGED_FLAG | ADD_V2_FLAG);

to fix this issue.

----------------------------------------------------------------------

Comment By: Robert Hegemann (robert)
Date: 2011-11-26 10:19

Message:
Thanks for reporting this issue, Talhei Monma!
Actually, the auto correction feature was missing in the unicode case too.
A fix will soon be available.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100290&aid=3441349&group_id=290