From: SourceForge.net <no...@so...> - 2011-11-02 07:45:27
|
Patches item #3431241, was opened at 2011-11-01 00:40 Message generated for change (Settings changed) made by tmkk You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300290&aid=3431241&group_id=290 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: libmp3lame Group: None >Status: Closed Resolution: Fixed Priority: 5 Private: No Submitted By: Taihei Monma (tmkk) Assigned to: Robert Hegemann (robert) Summary: Write little endian unicode tags for better compatibility Initial Comment: When adding unciode tags, current LAME implementation writes little or big endian unicode with a correct BOM, according to the machine endian and the endian of passed string. This is absolutely correct. But unfortunately, some bad-mannered software (including Windows Media Player) rejects tags with big endian unicode even if it has a correct BOM. So, for better compatibility, it is recommended to write little endian strings in any case. ---------------------------------------------------------------------- >Comment By: Taihei Monma (tmkk) Date: 2011-11-02 16:45 Message: Fine, now it works. ---------------------------------------------------------------------- Comment By: Robert Hegemann (robert) Date: 2011-11-02 04:53 Message: oop, sorry. Just noticed, the writeUcs2s function writes out hi-lo bytes, instead of lo-hi. fixed ---------------------------------------------------------------------- Comment By: Taihei Monma (tmkk) Date: 2011-11-02 03:33 Message: Thanks for your work, but now tags are always written in big endian order. The attached patch fixes the issue. ---------------------------------------------------------------------- Comment By: Robert Hegemann (robert) Date: 2011-11-02 02:23 Message: Thank you very much Taihei Monma, I've made your suggested change. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300290&aid=3431241&group_id=290 |