Re: [Lame-dev] autoconf stuff

[robert <Rob...@gm...>]

Am 26.03.2011, 23:00 Uhr, schrieb Alexander Leidinger  
<Ale...@le...>:

> On Sat, 26 Mar 2011 08:04:54 +0100 robert <Rob...@gm...>
> wrote:
>
>> Our autoconf magic stuff needs to get enhanced to detect the presence
>> of libiconv. When it's there, it shall define HAVE_ICONV preprocessor
>> symbol and add libiconv to the list of linked libraries.
>
> I try to get some time next week to have a look at it.

nice


>> Compiling LAME via Makefile.unix CFG=RH_SSE does use ICONV
>> and unicode support works. But, those using configure won't have
>> unicode support, until our configure magic adds it.
>>
>> Btw. our configure script offers some useless options too,
>> which should get removed, to simplify things.
>
> Can you please specify those which you have in mind?

We need to check all possible configure options, and re-evaluate
if they are still necessary.

What instantly comes to mind:
- the ALLFLOAT option isn't needed anymore, as several years ago
   the use of FLOAT8 was replaced by FLOAT. (Should we replace
   FLOAT by float ???)
- FLOAT8 is superfluous
- USE_LAYER_1 is superfluous
- USE_LAYER_2 is superfluous
- BRHIST is superfluous
- TAKEHIRO_IEEE754_HACK not good when targeting floating
   point architecture SSE2 (it's more a x87 thing),
   NASM seems to be of no benefit in this case too.


> Bye,
> Alexander.



Ciao Robert