Menu

#12 spaces around tags

open
5
2005-06-27
2005-06-27
No

Spaces around tags are removed.

hello.html
.--------------------
Hello <div id="mark:user">World</div> !
.--------------------

hello.plogic
.--------------------
#user {
plogic: {
print(user);
}
}
.--------------------

Spaces before <div> and after </div> are removed.

hello.rhtml
.--------------------
Hello<%= user %>!
.--------------------

It should be:
.--------------------
Hello <%= user %> !
.--------------------

release: 2.0.2

Discussion

  • Kuwata Makoto

    Kuwata Makoto - 2005-06-27
    • labels: --> kwartz-ruby
    • assigned_to: nobody --> kwatch
     
  • Kuwata Makoto

    Kuwata Makoto - 2005-06-28

    Logged In: YES
    user_id=221589

    patch:
    .--------------------
    --- lib/kwartz/converter.rb (revision 92)
    +++ lib/kwartz/converter.rb (working copy)
    @@ -91,14 +91,13 @@
    @is_whole_line = @is_begline && @is_endline
    @prev_last_char = @tag_str[-1]

    - #if @is_begline && @is_endline
    - # # nothing
    - #else
    - # @before_text += @before_space
    - # @before_space = ''
    - # @after_text = @after_space + @after_text
    - # @after_space = ''
    - #end
    + if !@is_begline && !@is_endline ## && @tagname ==
    'span'
    + @before_text += @before_space
    + @before_space = ''
    + @after_text = @after_space + @after_text
    + @after_space = ''
    + @tag_str.strip!
    + end

    @input = @after_text
    return @tagname
    .--------------------

    fixed: rev.93, release2.0.3
    test: ConverterTest#test_convert_span1() in
    test/converter-test.rb,
    SpanTest#test_span7() in test/compiler-test.rb

     

Log in to post a comment.