Re: [kvm-devel] [PATCH]0/2 Patches to furthure split kvm_init

[Christian E. <ehr...@li...>]

Hi Xiantao,
it looks good to me to move kvm_vcpu_cache out to the x86 specific code, but I wanted to suggest to go a bit further.
After your patch the structure kvm_vcpu_cache is only in x86/svm/vmx.c so we could prevent mistakes in two ways.
I send two extension patches which will fit on top of your 2 patch queue as suggestion and therefore call them 3/2 and 4/2.

[3/2] move_kvm_cpu_cache_to_x86_header
To prevent misuse of these x86 structure in generic code the definition moved from kvm.h to x86.h.

[4/2] rename_kvm_cpu_cache_x86
Renamed the kvm_vcpu_cache structure to kvm_x86_vcpu_cache to make clear to anyone who see's that variable in the code in future that it's x86 only.

Zhang, Xiantao wrote:
> [1/2] Fix missing bad_page free logic for possbile failures of kvm_init.
> [2/2] Moving kvm_vcpu_cache to x86.c, since it belongs to x86-specific
> part.
> 
> Signed-off-by: Zhang Xiantao <xia...@in...>
> 
> -------------------------------------------------------------------------
> SF.Net email is sponsored by: The Future of Linux Business White Paper
> from Novell.  From the desktop to the data center, Linux is going
> mainstream.  Let it simplify your IT future.
> http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4
> _______________________________________________
> kvm-devel mailing list
> kvm...@li...
> https://lists.sourceforge.net/lists/listinfo/kvm-devel


-- 

Grüsse / regards, 
Christian Ehrhardt

IBM Linux Technology Center, Open Virtualization
+49 7031/16-3385
Ehr...@li...
Ehr...@de...

IBM Deutschland Entwicklung GmbH
Vorsitzender des Aufsichtsrats: Johann Weihen 
Geschäftsführung: Herbert Kircher 
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294