Re: [kvm-devel] [PATCH 1/2] kvm: Fix x86 emulator writeback

[Avi K. <av...@qu...>]

Luca Tettamanti wrote:
> When the old value and new one are the same the emulator skips the
> write; this is undesiderable when the destination is a MMIO area and the
> write shall be performed regardless of the previous value. This
> optimization breaks e.g. a Linux guest APIC compiled without
> X86_GOOD_APIC.
>
> Remove the check and perform the writeback stage in the emulation unless
> it's explicitly disabled (currently push and some 2 bytes instructions
> may disable the writeback).
>
>   

Applied both, thanks.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.