Menu
▾
▴
kreatecd-devel
|
From: RAD K. 1 <kmr...@co...> - 2001-08-24 02:14:50
Attachments:
cancel.diff
|
It seems to me that the add/edit track dialog is begging for cancel button; add a new track then think twice and your only option is to hit okay and then delete the track. So, here's the beginnings of a patch that adds said functionality. Though it handles the case of a new track, it doesn't do anything for editing an existing track. I was unsure of the direction to go in with this because of the existing object structure and the fact that the edit window changes the CDTrack object at the same time as dialog changes are made. I also changed TrackWindow to be a QDialog and made it modal. This seemed logical since really there's no reason for it to not be. It's not like you can open multiple edit dialogs (and this doesn't really make sense anyway). Another issue I had in mind is configuration dialogs. One thing that really annoys me about adaptec ezcd creator is how it seems like the options that pertain to a specific burn and the options pertaining to the application/burner itself are mixed and spread over several dialogs. If you're just trying to do a quick burn, it's likely that you'll have to click all over the place. One thing that would be nice is if different types of configuration options are separated. Application/burner options can be in a dialog accessed through a menu, but it would be more convenient to have burn-specific options more easily accessible. So.. Thoughts? Guidance? Opinions? :) -- Kevin Radloff - RAD Kade 1 kmr...@co... http://shelled.nutz.org/~radkade1/ |
|
From: Niels R. <n.r...@pl...> - 2001-08-24 07:08:25
|
Op vrijdag 24 augustus 2001 04:14, schreef u: > It seems to me that the add/edit track dialog is begging for cancel > button; add a new track then think twice and your only option is to hit > okay and then delete the track. So, here's the beginnings of a patch > that adds said functionality. Though it handles the case of a new > track, it doesn't do anything for editing an existing track. I was > unsure of the direction to go in with this because of the existing > object structure and the fact that the edit window changes the CDTrack > object at the same time as dialog changes are made. > > I also changed TrackWindow to be a QDialog and made it modal. This > seemed logical since really there's no reason for it to not be. It's > not like you can open multiple edit dialogs (and this doesn't really > make sense anyway). I applied the patch, everything looked reasonable. > Another issue I had in mind is configuration dialogs. One thing that > really annoys me about adaptec ezcd creator is how it seems like the > options that pertain to a specific burn and the options pertaining to > the application/burner itself are mixed and spread over several > dialogs. If you're just trying to do a quick burn, it's likely that > you'll have to click all over the place. One thing that would be nice > is if different types of configuration options are separated. > Application/burner options can be in a dialog accessed through a menu, > but it would be more convenient to have burn-specific options more > easily accessible. OK, it annoys you with Adaptec EZCD creator, but does it annoy you with KreateCD? In the configuration dialog, one may set the standards, however, when the write CD button is pressed, one can change the burner settings there. Niels -- Ga eens wat vaker met de metro |
|
From: Alexander F. <Ale...@gm...> - 2001-08-24 10:34:48
|
On Friday, 24. August 2001 09:05, Niels Reedijk wrote: > Op vrijdag 24 augustus 2001 04:14, schreef u: > > It seems to me that the add/edit track dialog is begging for cancel > > button; add a new track then think twice and your only option is to hit > > okay and then delete the track. So, here's the beginnings of a patch > > that adds said functionality. Though it handles the case of a new > > track, it doesn't do anything for editing an existing track. I was > > unsure of the direction to go in with this because of the existing > > object structure and the fact that the edit window changes the CDTrack > > object at the same time as dialog changes are made. > > > > I also changed TrackWindow to be a QDialog and made it modal. This > > seemed logical since really there's no reason for it to not be. It's > > not like you can open multiple edit dialogs (and this doesn't really > > make sense anyway). > > I applied the patch, everything looked reasonable. > Ok, but we have to do the rest too. The cancel button has to restore the old track again if the cancelled track was not a new track and the used changed it. To do this we will probably have to clone the complete CDTrack object - with all objects stored in it. I hope we manage this in time. > > Another issue I had in mind is configuration dialogs. One thing that > > really annoys me about adaptec ezcd creator is how it seems like the > > options that pertain to a specific burn and the options pertaining to > > the application/burner itself are mixed and spread over several > > dialogs. If you're just trying to do a quick burn, it's likely that > > you'll have to click all over the place. One thing that would be nice > > is if different types of configuration options are separated. > > Application/burner options can be in a dialog accessed through a menu, > > but it would be more convenient to have burn-specific options more > > easily accessible. > > OK, it annoys you with Adaptec EZCD creator, but does it annoy you with > KreateCD? In the configuration dialog, one may set the standards, however, > when the write CD button is pressed, one can change the burner settings > there. > I think it is OK like this. Are there any additional configuration options that should be in the write dialog? Alexander |
|
From: RAD K. 1 <kmr...@co...> - 2001-08-24 12:17:56
|
On Friday 24 August 2001 06:02, you wrote: > Ok, but we have to do the rest too. The cancel button has to restore > the old track again if the cancelled track was not a new track and > the used changed it. To do this we will probably have to clone the > complete CDTrack object - with all objects stored in it. I hope we > manage this in time. > > Alexander Yeah, this is what I started doing then stopped when I realized there were api issues with the CDTrack destructor deleting the objects it references (which is bad if we copy the pointers :). I guess "bool throwaway" or something in the constructor is a simple and only slightly smelly fix. :) -- Kevin Radloff - RAD Kade 1 kmr...@co... http://shelled.nutz.org/~radkade1/ |
|
From: Alexander F. <Ale...@gm...> - 2001-08-24 14:18:17
|
On Friday, 24. August 2001 14:17, RAD Kade 1 wrote: > On Friday 24 August 2001 06:02, you wrote: > > Ok, but we have to do the rest too. The cancel button has to restore > > the old track again if the cancelled track was not a new track and > > the used changed it. To do this we will probably have to clone the > > complete CDTrack object - with all objects stored in it. I hope we > > manage this in time. > > > > Alexander > > Yeah, this is what I started doing then stopped when I realized there > were api issues with the CDTrack destructor deleting the objects it > references (which is bad if we copy the pointers :). I guess "bool > throwaway" or something in the constructor is a simple and only > slightly smelly fix. :) It is not the only problem that the destructor deletes the subobjects. The objects can be discared elsewhere too (when the user changes from audio track to data track (ISO 9660 mastering) - the AudioFileInfo gets discarded and an IsoImage object will be created ) Er even worse : the user only changes these objects - a cancel cannot undo these changes. I probably will implement copy constructors which will do a deep copy of the objects - not only pointers. Alexander |
|
From: RAD K. 1 <kmr...@co...> - 2001-08-24 11:30:43
|
On Friday 24 August 2001 03:05, you wrote: > OK, it annoys you with Adaptec EZCD creator, but does it annoy you > with KreateCD? In the configuration dialog, one may set the > standards, however, when the write CD button is pressed, one can > change the burner settings there. > > Niels Sorry for being vague (Can't manage to get enough sleep for the life of me lately :).. What I meant was that perhaps the ISO settings section of the existing configuration dialog belongs in its own menu entry or perhaps in a button or something. It's also ambiguous when using the classic dialog; the user has no idea of knowing (without experimenting) whether that changes existing ISO options or is the default or what (of course, it is in fact the default behavior). If it's not functioning as a dialog to set the default (in the case of the "Data CD only" interface where it decides the final behavior), it seems slightly odd that the options for the ISO are in a "Configure kreatecd" menu entry. It seems to me that things belonging in a "configure kreatecd" dialog are set once and forget about, while the ISO options are per-session. -- Kevin Radloff - RAD Kade 1 kmr...@co... http://shelled.nutz.org/~radkade1/ |
|
From: Alexander F. <Ale...@gm...> - 2001-08-24 12:13:23
|
On Friday, 24. August 2001 13:30, RAD Kade 1 wrote: > On Friday 24 August 2001 03:05, you wrote: > > OK, it annoys you with Adaptec EZCD creator, but does it annoy you > > with KreateCD? In the configuration dialog, one may set the > > standards, however, when the write CD button is pressed, one can > > change the burner settings there. > > > > Niels > > Sorry for being vague (Can't manage to get enough sleep for the life of > me lately :).. What I meant was that perhaps the ISO settings section > of the existing configuration dialog belongs in its own menu entry or > perhaps in a button or something. It's also ambiguous when using the > classic dialog; the user has no idea of knowing (without experimenting) > whether that changes existing ISO options or is the default or what (of > course, it is in fact the default behavior). Perhaps we should make it clear somehow that it is the DEFAULT setting for ISO options > If it's not functioning as > a dialog to set the default (in the case of the "Data CD only" > interface where it decides the final behavior), it seems slightly odd > that the options for the ISO are in a "Configure kreatecd" menu entry. > It seems to me that things belonging in a "configure kreatecd" dialog > are set once and forget about, while the ISO options are per-session. The settings in configure kreatecd are never per-session settings. I think we need an additional button in the "Data CD only" mode. The default configuration doesn't affect the data only CD track any more - once it is constructed Alexander |
|
From: RAD K. 1 <kmr...@co...> - 2001-08-24 21:43:09
|
On Friday 24 August 2001 08:09, you wrote: > Perhaps we should make it clear somehow that it is the DEFAULT > setting for ISO options Right.. I think merely the word "Default" would clear everything up. > The settings in configure kreatecd are never per-session settings. I > think we need an additional button in the "Data CD only" mode. The > default configuration doesn't affect the data only CD track any more > - once it is constructed > > Alexander What I meant by "per-session" was something that is likely to change with each session (ie, the ISO settings). If the ISO settings in the configuration dialog are default settings then there is no way to configure an ISO in data only mode. Since of course they are, an additional button would definitely be needed. :) -- Kevin Radloff - RAD Kade 1 kmr...@co... http://shelled.nutz.org/~radkade1/ |
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X