Menu

#78 Games crashes in Dungar's house

closed-fixed
nobody
None
5
2009-06-09
2009-05-26
Ryan Kohn
No

After retrieving the Opal Helmet, Dungar and his wife invite Noslom and Corrin for dinner. After I kill off the Assassin, I head to Dungar's room (his wife DID scream). I walk straight up through the door and the game crashes.

Discussion

  • Ryan Kohn

    Ryan Kohn - 2009-05-26

    Okay, I traced down the bug to line 148 of /scripts/estate.lua:
    set_ent_facing(en, FACE_DOWN)

    It's because 'en' isn't defined in this context.

    I think the intention was for the value to be wife:
    set_ent_facing(wife, FACE_DOWN)

    I tested the change on a local copy and verified that the game no longer crashes. How do I check these changes in?

    Thanks,
    Ryan

     
  • Anonymous

    Anonymous - 2009-05-29

    Thanks for this bug report and for fixing it too! The best way is for you to make a patch using cvs diff -u and post it here, then we'll apply it.

    Peter

     
  • Ryan Kohn

    Ryan Kohn - 2009-05-30

    Alright, I hope I did this right.

    --- scripts/estate.lua 18 Nov 2007 03:54:26 -0000 1.20
    +++ scripts/estate.lua 30 May 2009 05:41:24 -0000
    @@ -145,7 +145,7 @@
    local wife = 1

    set_progress(P_TALKGELIK, 4)
    - set_ent_facing(en, FACE_DOWN)
    + set_ent_facing(wife, FACE_DOWN)
    bubble(wife, _"Oh $0!")
    bubble(wife, _"I woke up because I thought I heard fighting in your room.")
    bubble(wife, _"When I turned to wake Dungar, I realized that he was dead.")

     
  • Anonymous

    Anonymous - 2009-06-09

    Applied to CVS

     
  • Anonymous

    Anonymous - 2009-06-09
    • status: open --> closed-fixed
     

Log in to post a comment.

MongoDB Logo MongoDB