From: Jeremy L. <jer...@m4...> - 2005-09-02 10:46:25
|
Hi Colin! > I will try and take a look at this at the weekend. Thanks Jeremy for po= inting > out these issues with the code. Attached are 3 patches I am planning to include in the next Debian upload= of KProf: - 01 : fix for a compilation error related to QTextStream - 02 : fix for the memory error I mentioned in my previous message (spott= ed with valgrind) - 03 : fix for the way KProf calculates "total" times based on gprof outp= ut. This bug was reported some time ago by Ross Boylan : http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D282137 This third patch is not optimised in terms of processor time as it makes = an extra call to "locateProfileEntry" for each primary entry in the gprof ca= ll tree. A better patch could be produced by having CParseProfile::processCallGraphBlock" return a pointer to the CProfileInf= o for the primary entry. I suggest we move this discussion to kpr...@li... = to avoid excessive Cc'ing :) Cheers, Jeremy -- http://www.jerryweb.org/ : JerryWeb.org http://sailcut.sourceforge.net/ : Sailcut CAD http://opensource.polytechnique.org/ : Polytechnique.org Free Software |