#78 entity_fiscal_calendars seed references calendars not present in demo data (~60 entities)

[Anonymous]

Originally created by: grynn-in

Context

PR [#76] fixed the demo entities (AMHQ/AMUS/AMDE) to point at the Standard fiscal calendar — the only calendar actually loaded from raw D365 (epm_raw.FiscalCalendarYears.Calendar = 'Standard').

Problem

The dbt_project/seeds/entity_fiscal_calendars.csv seed still maps ~60 other entities to fiscal_calendar_id values that don't exist in the demo raw data:

  52  Fiscal
   3  Fiscal_CN
   2  Fiscal_TH
   2  Fisscal_IN   <- also a typo (double 's')
   1  Fiscal_MY / Fiscal_SA / ADC-STD / CBD / CMBC-CAL / TDBF-STD

These entities are inert in the demo (no GL data), so they don't affect the current build — but any of them gaining data would hit the same calendar-join miss → fiscal fallback path that [#73]/#76 addressed. The seed is also internally inconsistent (e.g. the Fisscal_IN typo).

Proposal

Reconcile the seed with the calendars that actually exist: either (a) seed the referenced fiscal calendars into the raw/staging data, or (b) point these entities at Standard (or whatever real calendar applies), and fix the Fisscal_IN typo. Pair with the regression-guard test (companion issue) so a future mismatch fails loudly.

Surfaced in

Review of [#76].

[Anonymous]

Ticket changed by: grynn-in

• status: open --> closed