Re: [Klibido-devel] kde4

[Stefan <ste...@gm...>]

On Friday 04 January 2008 12:42:29 Stefan wrote:
> On Thursday 03 January 2008 21:12:25 Stefan wrote:
> > On Thursday 03 January 2008 14:54:23 Stefan wrote:
> > > On Thursday 03 January 2008 14:25:27 Bauno wrote:
> > > > On Thursday 3 January 2008 11:39:23 Stefan wrote:
> > > > > I don't think porting to kde4, refactoring kde3 version and then
> > > > > porting those changes is not a good idea, because refactoring
> > > > > probably changes most of the code which we'll than have to port
> > > > > twice.
> > > >
> > > > Of course, this is the downside...
> > > >
> > > > > Also, the kde4 version
> > > > > needs some refactoring, like model/view programming and I don't
> > > > > really like the idea of 2 refactorings.
> > > >
> > > > Me neither. So you think it'd better if the two versions evolved
> > > > independently for code? Only "ideas" should be ported between the two
> > > > versions? :)
> > > >
> > > > > I also noticed the code is messy, so maybe we can better go for a
> > > > > complete rewrite and only copy back some usefull stuff which
> > > > > doesn't require much changes.
> > > >
> > > > Be aware that rewriting != refactoring, and usually takes much
> > > > longer.
> > > >
> > > > > Does KJove have a cvs/svn/git/... somewhere so we can look at it?
> > > >
> > > > Nope...and I don't think the code can be made public right now...too
> > > > embarassing.
> > > >
> > > > > What do we do with version control? I don't care if we stick with
> > > > > cvs or move to svn or git, but I'd like to check in my changes as
> > > > > fast as possible if we go for the port.
> > > >
> > > > KLibido is on cvs.sourceforge.net, and I think it should remain
> > > > there. KLibido4 can be placed anywhere: in the same repository as a
> > > > subdir, or as another module, or on SVN or git. Dunno.
> > > > Questions: when will KDE4 be released? When will it be "universally"
> > > > adopted? When do you think we could stop maintaining the kde3
> > > > version? Ok, I know, in fact I already stopped maintaining it a year
> > > > ago or so
> > > >
> > > > :-\ ;-]
> > >
> > > kde4 is tagged tomorrow and released next week. Universally adopted, no
> > > idea, but not in the next few months I think (pure speculation of
> > > course). You can stop maintaining the kde3 version any time you want of
> > > course, but maybe the first release of the kde4 version is a good time?
> > > When we reach this point I think kde 4.0.1 should be out and be more
> > > stable and widely adopted.
> > >
> > > Maybe it is smart to keep the 2 versions in the same repo and if cvs is
> > > giving us any problems we can always move to somewhere else? There are
> > > cvs2git tools so this shouldn't be much of a problem.
> > >
> > > -----------------------------------------------------------------------
> > >-- This SF.net email is sponsored by: Microsoft
> > > Defy all challenges. Microsoft(R) Visual Studio 2005.
> > > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> > > _______________________________________________
> > > Klibido-devel mailing list
> > > Kli...@li...
> > > https://lists.sourceforge.net/lists/listinfo/klibido-devel
> >
> > I continued porting 0.2.5 and I think most of it is done. About half of
> > the files compile and the other half is mostly small stuff. Or at least
> > the part make -k gives errors about.
> > I did a diff between cvs and 0.2.5 and the bigger changes are only in a
> > few files.
> >
> > I gave refactoring a second thought and I think it won't make much sense
> > for 0.2.5 because I don't think many new features are added to this
> > version (or am I wrong?). I don't like to refactor the kde4 version
> > before we have a working because bug fixing will take much longer because
> > you'll need to run it to find bugs :p
> >
> > I'll stop for today, but I'll hope to have it compiling (running??)
> > tomorrow.
> >
> > -------------------------------------------------------------------------
> > This SF.net email is sponsored by: Microsoft
> > Defy all challenges. Microsoft(R) Visual Studio 2005.
> > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> > _______________________________________________
> > Klibido-devel mailing list
> > Kli...@li...
> > https://lists.sourceforge.net/lists/listinfo/klibido-devel
>
> It "runs"!
> I've commented out some useless :p things like the menu and database
> loading. There is a weird i18n thing after the filename for the database
> which, I think, makes the create functions for the database fail and all
> "get" statements fail after that. But since there are no return values for
> opening the database (yet) it tries to read anyway and crashes.
>
> I'm not going to post screenshots yet, because it looks like crap, but it
> runs :D
>
> Bauno: if you can give me cvs access I'll upload it to a branch, or if you
> want a (big) patch I can post that too on the mailing list.
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2005.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> Klibido-devel mailing list
> Kli...@li...
> https://lists.sourceforge.net/lists/listinfo/klibido-devel

It runs and downloads stuff now. Menu is fixed with the exception of some 
missing icons. Some icons come from kdenetwork so you need that one too, but 
I haven't been able to find some others (see debug output if you want the 
names).

Attached is a diff between 0.2.5 and my version, so have fun ;)

Had to bzip it because the diff is 1.4MB...