Menu

#2 Support for libnjb 2.0

closed-accepted
nobody
None
5
2005-02-24
2005-01-15
ace jones
No

* Ported to new libnjb 2.0 library (now requires a CVS
snapshot as of 2004-12-10 or later)

* Fixed memory leak in kio_njbProtocol::open(). "m_njb
= new njb_t; m_njb = njbs;" leaks the result from new,
AND leaves m_njb pointing to a stack-allocated object,
ensuring a crash when it's later deleted.

* Replaced all putTrackProgress_njb-style static
pointers used in progress functions with a
reinterpreted void* from the args list (i.e. the "xxx
fixme instance pointer" comments)

* Make capturing optional in
kio_njbProtocol::connect(). Not all functions need to
have the device captured, and over-capturing tended to
produce unstable results.

* Added more error checking

* Added lots of __func__ uses, replacing hardcoded
function names

Discussion

  • ace jones

    ace jones - 2005-01-15

    libnjb-2.0-patch.gz

     
  • ace jones

    ace jones - 2005-02-17
    • status: open --> pending
     
  • ace jones

    ace jones - 2005-02-17

    Logged In: YES
    user_id=954547

    This patch has been integrated into the steup branch in CVS.

     
  • ace jones

    ace jones - 2005-02-17
    • status: pending --> pending-accepted
     
  • ace jones

    ace jones - 2005-02-24
    • status: pending-accepted --> open-accepted
     
  • ace jones

    ace jones - 2005-02-24
    • status: open-accepted --> closed-accepted
     

Log in to post a comment.