Re: [Kile-devel] Drag-and-Drop

[Thomas B. <br...@ph...>]

Am Wednesday 19 July 2006 21:03 schrieb Michel Ludwig:
> Hi,
>
> On Wednesday 19 July 2006 20:21, Thomas Braun wrote:
> > Hello,
> >
> > is it necessary to use QFile::decodeName to get properly encoded
> > filenames?
>
> I don't think so as URLs could also represent remote documents (for
> example, files that are accessed via sftp). I've just checked it and at the
> moment, the method "symlinkFreeURL" in "kiledocmanager.cpp" prevents this.
> Maybe, that method should be changed so that it only works on URLs that
> represent local files ?

Okay I only thought about local files when designing symlinkFreeURL.

I think this change should be sufficient.

@@ -1721,6 +1727,10 @@ void Manager::projectAddFile(QString fil
 const KURL Manager::symlinkFreeURL(const KURL& url)
 {
        kdDebug() << "===symlinkFreeURL==" << endl;
+
+       if( !url.isLocalFile() )
+               return url;
+
        QDir dir(url.directory());
        QString filename=url.path(); // if the directory does not exist we 
return the old url (just to be sure)

Have you checked (the old decoding problem) with an UTF8 default system with 
umlauts in the flename which you drop ?
If not I can do that also, I have a opensuse 10.0 lying around.

> > > If everything is alright, shall I commit the patch to "branches" as
> > > well ?
> >
> > If you would ask me I would say no, but ...
>
> OK. Are there any plans yet for Kile 2.0 ?

I don't know about official plans yet, we just want code best kile ever :)

Thomas