From: Andreas Cord-L. <cor...@kd...> - 2015-07-28 06:08:45
|
> On Juli 27, 2015, 7:35 nachm., Michel Ludwig wrote: > > src/kileviewmanager.cpp, line 138 > > <https://git.reviewboard.kde.org/r/124367/diff/3/?file=387747#file387747line138> > > > > Can you call this method 'textViewAtTab' and use it instead of m_tabBar->tabData(i).value<KTextEditor::View*>()? > > > > This should increase the readbility of the code. There are only two cases where this conversion (widget to KTextEditor::View) applies, since most are already qvariant to view. Yet a general qvariant to KTextEditor::View conversion method would look quite strange to me. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124367/#review83063 ----------------------------------------------------------- On Juli 26, 2015, 8:37 vorm., Andreas Cord-Landwehr wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124367/ > ----------------------------------------------------------- > > (Updated Juli 26, 2015, 8:37 vorm.) > > > Review request for Kile. > > > Repository: kile > > > Description > ------- > > Replace the former QTabWidget by a combination of QTabBar and QStackedWidget to make the interface more flexible. > This is needed for the following review request for adding a quick access menu. > > Seems I am unable to create a new review request that is based on this patch's hash. So for now I am appending the next patch in line to explain what I am up to do: Like in KDevelop the tab bar with all document names gains a small menu to access all currently open documents. That is usefull in particular, if you have many open documents at once/some documents open at once and the livepreview on, since in those cases the tab navigation is very slow to use. > > > Diffs > ----- > > src/kile.cpp 8b5a40d > src/kileviewmanager.h 7f7b87d > src/kileviewmanager.cpp a112d29 > > Diff: https://git.reviewboard.kde.org/r/124367/diff/ > > > Testing > ------- > > manual testing. > > > File Attachments > ---------------- > > Patch for adding context menu with quick access to documents > https://git.reviewboard.kde.org/media/uploaded/files/2015/07/15/0c297279-fcca-4a6f-a4aa-09d860ddbd7d__0001-Add-quick-access-menu-for-all-open-documents.patch > > > Thanks, > > Andreas Cord-Landwehr > > |