From: Andreas Cord-L. <cor...@kd...> - 2015-07-22 15:30:13
|
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124367/ ----------------------------------------------------------- (Updated Juli 20, 2015, 6:04 nachm.) Review request for Kile. Changes ------- Thanks for the review! By parting the patch initially I actually wanted to make reviewing it easier (first patch changing logic without new features, second patch new menu). Anyways, now I created a joint patch of both commits (though planning to submit them as individual commits for the sake of a cleaner history). Regarding the documents menu, I applied all changes. However for the tabbar, I do not see a good way to access documents only by View pointers. The major problem is, how to select the correct View to show if the index in the tabbar changes. The index is the only information I can get from the tabbar. Repository: kile Description ------- Replace the former QTabWidget by a combination of QTabBar and QStackedWidget to make the interface more flexible. This is needed for the following review request for adding a quick access menu. Seems I am unable to create a new review request that is based on this patch's hash. So for now I am appending the next patch in line to explain what I am up to do: Like in KDevelop the tab bar with all document names gains a small menu to access all currently open documents. That is usefull in particular, if you have many open documents at once/some documents open at once and the livepreview on, since in those cases the tab navigation is very slow to use. Diffs (updated) ----- src/kile.cpp 8b5a40d src/kileviewmanager.h 7f7b87d src/kileviewmanager.cpp a112d29 Diff: https://git.reviewboard.kde.org/r/124367/diff/ Testing ------- manual testing. File Attachments ---------------- Patch for adding context menu with quick access to documents https://git.reviewboard.kde.org/media/uploaded/files/2015/07/15/0c297279-fcca-4a6f-a4aa-09d860ddbd7d__0001-Add-quick-access-menu-for-all-open-documents.patch Thanks, Andreas Cord-Landwehr |