|
From: Michel L. <mic...@gm...> - 2015-04-03 20:11:42
|
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122895/#review78460 ----------------------------------------------------------- Ship it! Ship It! - Michel Ludwig On April 1, 2015, 8:35 p.m., Andreas Cord-Landwehr wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122895/ > ----------------------------------------------------------- > > (Updated April 1, 2015, 8:35 p.m.) > > > Review request for Kile and Michel Ludwig. > > > Repository: kile > > > Description > ------- > > This fixes the insertion of LaTeX snippets when enter is pressed in the completion list. The patch works around a "funny" behavior of the LaTeXCompletionModel::data method which eventually should also be revisited. > > I am mostly posting this to reviewboard, since I am unsure if this should be worked around or if there is currently more work planed for refactoring this model (last commit to this class indicates so). > > > Diffs > ----- > > src/codecompletion.cpp e23d68a > > Diff: https://git.reviewboard.kde.org/r/122895/diff/ > > > Testing > ------- > > Manual testing. > > > Thanks, > > Andreas Cord-Landwehr > > |