Re: [Kile-devel] Some patches

[Michel L. <mic...@kd...>]

Hi Thomas,

On Tuesday 27 May 2008 20:52:13 Thomas Braun wrote:
> One removes our implementations of relativePath with KUrl::relative().
> As far as I can judge there are no regressions.

This patch looks ok to me.

> The second one removes the hover button from the tabwidget.
> It is replaced with a standard popup-menu inspired by kdevelop.
> I personally dislike the hover-button because it is unintuitive and hidden.
> The context menu is nearly as quick and the quickest is of course the
> shortcut.

What widget style are you using? Even without the patch, I get Firefox-style 
close buttons, i.e. every tab contains a close button on the right-hand side. 
Actually, I prefer hover buttons, but the way it is done in Firefox is also 
ok for me. So, I guess we can add a popup menu too.

Please note that there are some code formatting issues with the patch: please 
use NULL to denote null pointers and can you also put brackets around 
single-line if-statements?

And maybe you can rewrite this

	KTextEditor::View *view = 0L;

	for(QList<KTextEditor::View*>::iterator i =  m_textViewList.begin(); i != 
                                                  m_textViewList.end(); ++i) {
		if( *i == widget ){
			view = *i;
			break;
		}
	}

	if( view == 0L)
		return; 

into 

	KTextEditor::View *view = dynamic_cast<KTextEditor::View*>(widget);
	if(!widget) {
		return;
	}

> Another question:
> Currently the kile moc files are not updated on my system. I have to do a
> make clean and make to get them updated.
> I tried to add kde4_automoc(${kile_SRCS}$) but this could not be found.
> Any ideas?

There seems to be a problem with moc file dependencies lately. As far as I 
know, it will still take some mean before a real fix for this problem is 
committed. In the mean time deleting the offending moc file and doing 'make' 
usually does the trick for me.

Michel