One problem I see with pcre is that one loses some habilities. For example, using the perl interpreter it is possible to use variables defined in the perl interpreter when matching, and possibly some other fancy tricks. Not something done all the time, but someone could find an use.
Also, why did you drop gag and highlight? I might use the pcre suggestion, but why did you drop the features? They may be useful for other people.
Finally, please try to send the patch as an actual patch (output of diff program), it is easier to see the changes that way.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2010-06-13
I delete them because they cost 2 times matching.
PCRE don't support various of encodings,so this patch only work on platforms with utf-8 locale.
You must make a big change to use it in the generic verison.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
UTF-8 is not a problem, KildClient always works internally with UTF-8 (even if the server uses another encoding).
I'll not apply this patch as it is, because it drops functionalities that people use. I may in a future make some experiments with pcre and see if it has benefits, though.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
high speed patch for utf-8 platform,use pcre,drop "gag" and "highlight"
copy the 5 files to src, then make&&make install
Is pcre much faster? Did you make any timings?
One problem I see with pcre is that one loses some habilities. For example, using the perl interpreter it is possible to use variables defined in the perl interpreter when matching, and possibly some other fancy tricks. Not something done all the time, but someone could find an use.
Also, why did you drop gag and highlight? I might use the pcre suggestion, but why did you drop the features? They may be useful for other people.
Finally, please try to send the patch as an actual patch (output of diff program), it is easier to see the changes that way.
I delete them because they cost 2 times matching.
PCRE don't support various of encodings,so this patch only work on platforms with utf-8 locale.
You must make a big change to use it in the generic verison.
diff files
UTF-8 is not a problem, KildClient always works internally with UTF-8 (even if the server uses another encoding).
I'll not apply this patch as it is, because it drops functionalities that people use. I may in a future make some experiments with pcre and see if it has benefits, though.
Good idea.
I change the code because my platform is too slow in last months, this patch is only fit the slow computers.